Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #41533
Closed
arielb1 wants to merge 22 commits into
Closed
Conversation
Also spell out that read and write operations should be retried on `ErrorKind::Interrupted` errors. Fixesrust-lang#38494.
Turns out all six of these impls are incorrect.
Adds rust-windbg.cmd script Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start. This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc. Example usage from cmd or PowerShell: ``` rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe ```
Check privacy of trait items in all contexts Fixesrust-lang#28514 This is a sufficiently rare scenario and it's currently guarded by `private_in_public` lint, so it shouldn't be a [breaking-change] in practice.
…richton Add bootstrap support for android
Specify behavior of `write_all` for `ErrorKind::Interrupted` errors Also spell out that read and write operations should be retried on `ErrorKind::Interrupted` errors. Fixesrust-lang#38494.
Add internal accessor methods to io::{Chain, Take}.
Resolvesrust-lang#29067.Step::replace_one should put a one, not a zero (Issue rust-lang#41492) Turns out all six of the replace_* impls were backwards.
use the word 'length' in Vec::len's docs Fixesrust-lang#37866
Fix a copy-paste error in `Instant::sub_duration` Fixesrust-lang#41514.
Clean up TcpStream example Fixesrust-lang#35950
rust-highfive
commented
Apr 25, 2017
Contributor
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
arielb1
commented
Apr 25, 2017
ContributorAuthor
@bors r+ p=10 |
bors
commented
Apr 25, 2017
Collaborator
📌 Commit a1a19e6 has been approved by |
bors
commented
Apr 25, 2017
Collaborator
⌛ Testing commit a1a19e6 with merge 4e30e41... |
bors
commented
Apr 25, 2017
Collaborator
💔 Test failed - status-travis |
Contributor
Seems like a legit failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_allforErrorKind::Interruptederrors #41442, Add internal accessor methods to io::{Chain, Take}. #41463, Step::replace_one should put a one, not a zero (Issue #41492) #41493, use the word 'length' in Vec::len's docs #41500, Fix a copy-paste error inInstant::sub_duration#41518, Clean up TcpStream example #41526