Uh oh!
There was an error while loading. Please reload this page.
rustc_trans: do not treat byval as using up registers. - #41378
Merged
Conversation
rust-highfive
commented
Apr 18, 2017
Contributor
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
arielb1
commented
Apr 18, 2017
Contributor
@bors r+ |
bors
commented
Apr 18, 2017
Collaborator
📌 Commit 0b35af9 has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…elb1 rustc_trans: do not treat byval as using up registers. Perhaps not that well-documented, `byval` pointer arguments *are not* the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the *contents* on the stack. Fixesrust-lang#41375.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…elb1 rustc_trans: do not treat byval as using up registers. Perhaps not that well-documented, `byval` pointer arguments *are not* the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the *contents* on the stack. Fixesrust-lang#41375.
frewsxcv
commented
Apr 18, 2017
Contributor
There's a travis failure @bors r- |
eddybforce-pushed
the
byval-is-not-like-sret
branch
from
April 18, 2017 23:23
0b35af9 to
cba0c6aCompareeddyb
commented
Apr 18, 2017
ContributorAuthor
@bors r=arielb1 |
bors
commented
Apr 18, 2017
Collaborator
📌 Commit cba0c6a has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…elb1 rustc_trans: do not treat byval as using up registers. Perhaps not that well-documented, `byval` pointer arguments *are not* the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the *contents* on the stack. Fixesrust-lang#41375.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 19, 2017
…elb1 rustc_trans: do not treat byval as using up registers. Perhaps not that well-documented, `byval` pointer arguments *are not* the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the *contents* on the stack. Fixesrust-lang#41375.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 20, 2017
…elb1 rustc_trans: do not treat byval as using up registers. Perhaps not that well-documented, `byval` pointer arguments *are not* the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the *contents* on the stack. Fixesrust-lang#41375.
nikomatsakis
commented
Apr 20, 2017
Contributor
Marking as beta-accepted. Small, blocks servo/firefox FFI. cc @rust-lang/compiler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perhaps not that well-documented,
byvalpointer arguments are not the same as pointer arguments used by pass-by-ref, but rather the pointer is only used by LLVM to pass the contents on the stack.Fixes#41375.