Uh oh!
There was an error while loading. Please reload this page.
Override ToOwned::clone_into for Path and OsStr - #41390
Conversation
The only non-overridden one remaining is the CStr impl, which cannot be optimized as doing so would break CString's second invariant.
rust-highfive
commented
Apr 19, 2017
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
aidanhs
commented
Apr 19, 2017
Thanks for the PR! We'll make sure @alexcrichton or another reviewer gets to your PR soon. |
alexcrichton
commented
Apr 19, 2017
bors
commented
Apr 19, 2017
📌 Commit 295bcdb has been approved by |
…crichton Override ToOwned::clone_into for Path and OsStr The only non-overridden one remaining is the CStr impl, which cannot be optimized as doing so would break CString's second invariant. Follow-up to 7ec27ae (PR rust-lang#41009). r? @alexcrichton
…crichton Override ToOwned::clone_into for Path and OsStr The only non-overridden one remaining is the CStr impl, which cannot be optimized as doing so would break CString's second invariant. Follow-up to 7ec27ae (PR rust-lang#41009). r? @alexcrichton
The only non-overridden one remaining is the CStr impl, which cannot
be optimized as doing so would break CString's second invariant.
Follow-up to 7ec27ae (PR #41009).
r? @alexcrichton