Uh oh!
There was an error while loading. Please reload this page.
Move RangeArgument and Bound to libcore. - #41460
Conversation
rust-highfive
commented
Apr 22, 2017
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Thanks for the PR! We’ll periodically check in on it to make sure that @aturon or someone else from the team reviews it soon. It also looks like there are some compilation failures, so perhaps you could take a look at those? |
4c65c78 to
f12fa92Comparef12fa92 to
688cbdaCompareclarfonthey
commented
Apr 24, 2017
I think that everything should be fixed now! |
Mark-Simulacrum
commented
Apr 24, 2017
Looks like that's not quite true: some feature attributes need to be added to a few crates: https://travis-ci.org/rust-lang/rust/jobs/225394483#L780. This is somewhat concerning, as that implies that moving this feature changed from stable to unstable? Or otherwise made things "now unstable," which feels like a regression? Might want to pay careful attention to the stability attributes... not certain. |
aturon
commented
Apr 24, 2017
cc @rust-lang/libs, I believe this change is in line with our general philosophy around |
alexcrichton
commented
Apr 25, 2017
This seems reasonable to me, but note that it's adding a new insta-stable type, What's the rationale for the movement to justify the duplication? |
clarfonthey
commented
Apr 25, 2017
I hadn't considered this, and you're right. I could make a |
alexcrichton
commented
May 4, 2017
@aturon it's been awhile since you last looked at this, mind giving it another look with an eye towards reviewing? |
Mark-Simulacrum
commented
May 7, 2017
@clarcharr Looks like there are quite a few compilation failures due to feature gating, could you take a look? |
Mark-Simulacrum
commented
May 14, 2017
@clarcharr Thanks for the contribution! The change looks good to me but it needs some changes still, see the Travis failure. Do you think you'll have a chance to make them soon? |
carols10cents
commented
May 22, 2017
Hi @clarcharr, thank you for your PR! Since there hasn't been any activity on this recently, we're going to close this to keep our open PR list current, but please feel free to reopen this when you have time to work on this again ❤️ |
This moves them to
core::opswith the rest of theRangetypes and re-exports them incollections.Right now, there's no reason why these shouldn't be accessible in libcore. Caution is due, however, because this would add
Boundto libcore as stable immediately.Also as a side note, it may be desirable in the future to split up
libcore/ops.rsas it is getting rather big.