Uh oh!
There was an error while loading. Please reload this page.
Refactor core::ops, move RangeArgument to libcore::ops - #42269
Refactor core::ops, move RangeArgument to libcore::ops#42269clarfonthey wants to merge 7 commits into
Conversation
rust-highfive
commented
May 27, 2017
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
May 28, 2017
Looks like travis failed: |
bors
commented
Jun 1, 2017
☔ The latest upstream changes (presumably #42348) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrum
commented
Jun 4, 2017
@clarcharr Looks like this is still waiting on some fixes from you... I guess still waiting on #42268 though. |
aidanhs
commented
Jun 8, 2017
r? @alexcrichton @clarcharr is it possible/does it make sense for you to separate out the two PRs? I realise it's probably a bit of a pain to unpick, but it looks like the other one may be stalled for now? |
clarfonthey
commented
Jun 8, 2017
@aidanhs I will do that! it makes sense either way |
clarfonthey
commented
Jun 8, 2017
Also I have to redo this anyway because of the |
Refactor ops.rs This refactors ops.rs into several different modules internally, as the file has gotten quite big. None of these modules are actually exported, but this should make maintaining it much easier. I've avoided the ambition of exporting the modules because they can more easily be rearranged after this commit goes through, even though it'd be cool to potentially export the modules in the future. I've separated the creation of each file into a separate commit so that this is easier to read. Redone version of #42269 with the movement of `RangeArgument` moved.
This is a redone version of most of #41460 that moves
RangeArgumenttocore::ops. This also refactorscore::opsinto submodules so that it's a bit easier to tell where things are.This relies on #42268.