Skip to content

LLVM: Update submodule to fix incorrect codegen on MSP430. - #41556

Merged
bors merged 1 commit into
rust-lang:masterfrom
pftbest:fix_msp430_codegen
Apr 28, 2017
Merged

LLVM: Update submodule to fix incorrect codegen on MSP430.#41556
bors merged 1 commit into
rust-lang:masterfrom
pftbest:fix_msp430_codegen

Conversation

@pftbest

@pftbestpftbest commented Apr 26, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

The bug was reported by @akovaski here:
rust-embedded/wg#20 (comment)

P.S. Looks like this patch will conflict with Hexagon changes.

r? @alexcrichton

@rust-highfive

rust-highfive commented Apr 26, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

alexcrichton commented Apr 26, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Apr 26, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 7e2f3d8 has been approved by alexcrichton

@bors

bors commented Apr 27, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #41567) made this pull request unmergeable. Please resolve the merge conflicts.

@pftbest
pftbestforce-pushed the fix_msp430_codegen branch from 7e2f3d8 to ec5588bCompareApril 27, 2017 05:41
@pftbest

pftbest commented Apr 27, 2017

Copy link
Copy Markdown
ContributorAuthor

Fixed merge conflict.

@alexcrichton

alexcrichton commented Apr 27, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Apr 27, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit ec5588b has been approved by alexcrichton

arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 27, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#41556- pftbest:fix_msp430_codegen, r=alexc…
b83da2d
…richton
LLVM: Update submodule to fix incorrect codegen on MSP430.
The bug was reported by @akovaski here:
rust-embedded/wg#20 (comment)
~~P.S. Looks like this patch will conflict with Hexagon changes.~~
r? @alexcrichton
@arielb1arielb1 mentioned this pull request Apr 27, 2017
Closed
@alexcrichtonalexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 27, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 27, 2017
@frewsxcv
Rollup merge ofrust-lang#41556- pftbest:fix_msp430_codegen, r=alexc…
f469c4a
…richton
LLVM: Update submodule to fix incorrect codegen on MSP430.
The bug was reported by @akovaski here:
rust-embedded/wg#20 (comment)
~~P.S. Looks like this patch will conflict with Hexagon changes.~~
r? @alexcrichton
@frewsxcvfrewsxcv mentioned this pull request Apr 27, 2017
Merged
bors added a commit that referenced this pull request Apr 28, 2017
@bors
Auto merge of#41591- frewsxcv:rollup, r=frewsxcv
70baf4f
Rollup of 7 pull requests
- Successful merges: #41438, #41523, #41526, #41546, #41556, #41572, #41578
- Failed merges:
@bors
bors merged commit ec5588b into rust-lang:masterApr 28, 2017
@pftbest
pftbest deleted the fix_msp430_codegen branch July 23, 2019 21:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pftbest@rust-highfive@alexcrichton@bors