Uh oh!
There was an error while loading. Please reload this page.
remove the #[inline] attribute from drop_in_place - #41920
Merged
Conversation
eddyb
commented
May 11, 2017
Contributor
@bors r+ |
bors
commented
May 11, 2017
Collaborator
📌 Commit c7b61fc has been approved by |
Apparently LLVM has exponential code growth while inlining landing pads if that attribute is present. Fixesrust-lang#41696.
arielb1
commented
May 11, 2017
ContributorAuthor
added a comment to test @bors r=eddyb |
bors
commented
May 11, 2017
Collaborator
📌 Commit b0c80a9 has been approved by |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 12, 2017
remove the #[inline] attribute from drop_in_place Apparently LLVM has exponential code growth while inlining landing pads if that attribute is present. Fixesrust-lang#41696. beta-nominating because regression. r? @eddyb
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 12, 2017
remove the #[inline] attribute from drop_in_place Apparently LLVM has exponential code growth while inlining landing pads if that attribute is present. Fixesrust-lang#41696. beta-nominating because regression. r? @eddyb
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 12, 2017
remove the #[inline] attribute from drop_in_place Apparently LLVM has exponential code growth while inlining landing pads if that attribute is present. Fixesrust-lang#41696. beta-nominating because regression. r? @eddyb
arielb1
commented
May 12, 2017
ContributorAuthor
I want perf stats. Let's merge this out of rollup @bors p=100 |
bors
commented
May 12, 2017
Collaborator
bors
commented
May 12, 2017
Collaborator
💔 Test failed - status-travis |
alexcrichton
commented
May 12, 2017
Member
|
alexcrichton
commented
May 12, 2017
Member
If that's because of an older LLVM bug then it's possible to tag this test with |
arielb1
commented
May 13, 2017
ContributorAuthor
@bors r=eddyb |
bors
commented
May 13, 2017
Collaborator
📌 Commit 237dbe9 has been approved by |
bors
commented
May 13, 2017
Collaborator
bors
commented
May 13, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
nikomatsakis
commented
May 17, 2017
Contributor
Accepting for beta; small patch, exponential code growth regression. cc @rust-lang/compiler |
nikomatsakis
commented
May 17, 2017
Contributor
Backport in #42053 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently LLVM has exponential code growth while inlining landing pads
if that attribute is present.
Fixes#41696.
beta-nominating because regression.
r? @eddyb