Uh oh!
There was an error while loading. Please reload this page.
Rollup of 14 pull requests - #41929
Closed
Mark-Simulacrum wants to merge 32 commits into
Closed
Conversation
Mark-Simulacrum
commented
May 12, 2017
Member
- Successful merges: Windows io::Error: also format NTSTATUS error codes #41684, enforce WF conditions after generalizing #41716, bootstrap: Output name of failed config in case of errors #41820, Remove wrong or outdated info from CString docs. #41860, doc: break into 2 sentences #41896, Number of filtered out tests in tests summary #41910, Upgrade some comments to doc comments #41912, Fix typo in Iterator::size_hint example comment #41916, Annotate the license exceptions #41918, Include the crate's root module in save-analysis #41919, remove the #[inline] attribute from drop_in_place #41920, Fix search when looking to sources #41921, rustc_trans: do not attempt to truncate an i1 const to i1. #41923, box large variants in MIR #41926
- Failed merges:
The new messages seem universally better. I think these result because we recognize that we are in an invariant context more often.
Apparently LLVM has exponential code growth while inlining landing pads if that attribute is present. Fixesrust-lang#41696.
Operand: 72 -> 24 B Statement: 192 -> 96 B Terminator: 256 -> 112 B librustc translation memory usage: 1795 -> 1669 MB next step would be interning lvalues, I suppose?
…ichton Windows io::Error: also format NTSTATUS error codes `NTSTATUS` errors may be encoded as `HRESULT`, see [[MS-ERREF]](https://msdn.microsoft.com/en-us/library/cc231198.aspx). These error codes can still be formatted using `FormatMessageW` but require some different parameters to be passed in. I wasn't sure if this needed a test and if so, how to test it. Presumably we wouldn't want to make our tests dependent on localization-dependent strings returned from `FormatMessageW`. Users that get an `err: NTSTATUS` will need to do `io::Error::from_raw_os_error(err|0x1000_0000)` (the equivalent of [`HRESULT_FROM_NT`](https://msdn.microsoft.com/en-us/library/ms693780(VS.85).aspx))
enforce WF conditions after generalizing Add a `WF(T')` obligation after generalizing `T` to `T'`, if `T'` contains an unconstrained type variable in a bivariant context. Fixesrust-lang#41677. Beta nominating -- regression. r? @arielb1
bootstrap: Output name of failed config in case of errors
Remove wrong or outdated info from CString docs. None
doc: break into 2 sentences
Number of filtered out tests in tests summary Closesrust-lang#31905
Upgrade some comments to doc comments
Fix typo in Iterator::size_hint example comment
Annotate the license exceptions
Include the crate's root module in save-analysis r? @eddyb
remove the #[inline] attribute from drop_in_place Apparently LLVM has exponential code growth while inlining landing pads if that attribute is present. Fixesrust-lang#41696. beta-nominating because regression. r? @eddyb
…steveklabnik Fix search when looking to sources Before: <img width="1440" alt="screen shot 2017-05-11 at 22 33 28" src="https://cloud.githubusercontent.com/assets/3050060/25970761/03fd2ade-369a-11e7-9fd6-783c23455589.png"> After: <img width="1440" alt="screen shot 2017-05-11 at 22 34 05" src="https://cloud.githubusercontent.com/assets/3050060/25970770/09ac71ce-369a-11e7-9038-559f414e07b5.png"> r? @rust-lang/docs
rustc_trans: do not attempt to truncate an i1 const to i1. Fixesrust-lang#41744 by skipping the truncation when it'd be a noop anyway.
box large variants in MIR Operand: 72 -> 24 B Statement: 192 -> 96 B Terminator: 256 -> 112 B librustc translation memory usage: 1795 -> 1669 MB next step would be interning lvalues, I suppose? cc rust-lang#36799 (@urschrei - does ostn15_phf compile with this PR?) r? @eddyb
rust-highfive
commented
May 12, 2017
Contributor
Some changes occurred in HTML/CSS. |
rust-highfive
commented
May 12, 2017
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
May 12, 2017
MemberAuthor
Woops, included an already being-tested PR... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.