Skip to content

appveyor: Wrap handle.exe download in a retry - #41996

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:more-retry
May 16, 2017
Merged

appveyor: Wrap handle.exe download in a retry#41996
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:more-retry

Conversation

@alexcrichton

@alexcrichtonalexcrichton commented May 14, 2017

Copy link
Copy Markdown
Member

Should help deal with spurious download failures.

@rust-highfive

rust-highfive commented May 14, 2017

Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichtonalexcrichton mentioned this pull request May 14, 2017
Merged
@Mark-Simulacrum

Mark-Simulacrum commented May 14, 2017

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 14, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit e5ec073 has been approved by Mark-Simulacrum

@Mark-Simulacrum

Mark-Simulacrum commented May 14, 2017

Copy link
Copy Markdown
Member

@bors p=20

We keep hitting this...

@bors

bors commented May 14, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e5ec073 with merge 8f01693...

@bors

bors commented May 15, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@Mark-Simulacrum

Mark-Simulacrum commented May 15, 2017

Copy link
Copy Markdown
Member

I guess we failed to retry? After 3 hours of retrying? This seems suspicious..

https://ci.appveyor.com/project/rust-lang/rust/build/1.0.3252/job/s26dwj5huwd7x8fs

@bors retry

00:00:39] Added C:\ProgramData\chocolatey\bin\ISCC.exe shim pointed to 'c:\program files (x86)\inno setup 5\iscc.exe'.
[00:00:39] The install of innosetup was successful.
[00:00:39] Software installed as 'exe', install location is likely default.
[00:00:39]
[00:00:39] Chocolatey installed 2/2 packages. 0 packages failed.
[00:00:39] See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
[00:00:39] set PATH="C:\Program Files (x86)\Inno Setup 5";%PATH%
[00:00:39] appveyor-retry appveyor DownloadFile https://download.sysinternals.com/files/Handle.zip

@ishitatsuyuki

ishitatsuyuki commented May 15, 2017

Copy link
Copy Markdown
Contributor

Time to mirror it. It may just being the network hanging.

@bors

bors commented May 15, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e5ec073 with merge 372c218...

@bors

bors commented May 15, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@Mark-Simulacrum

Mark-Simulacrum commented May 15, 2017

Copy link
Copy Markdown
Member

Downloading Handle.zip (316,667 bytes)...6% Progress!

@bors retry

@ishitatsuyuki

ishitatsuyuki commented May 15, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

@Mark-Simulacrum I'd rather recommend to calm down and fix this to use a mirror. I have no idea who has access to S3, but I guess it's not only granted to Alex. You should also be able modify the commit in that case.

@bors

bors commented May 15, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e5ec073 with merge bfeb076...

@bors

bors commented May 15, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@kennytm

kennytm commented May 15, 2017

Copy link
Copy Markdown
Member

Travis:

[01:29:00] error: unable to get packages from source
[01:29:00] [01:29:00] Caused by:
[01:29:00] failed to get 200 response from `https://crates.io/api/v1/crates/utf8-ranges/0.1.3/download`, got 500

I thought it was fixed in #41978? And utf8-ranges again?

@ishitatsuyukiishitatsuyuki mentioned this pull request May 15, 2017
Merged
@carols10centscarols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 15, 2017
@petrochenkovpetrochenkov mentioned this pull request May 15, 2017
Merged
@alexcrichton

alexcrichton commented May 15, 2017•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@bors: retry

@alexcrichton

alexcrichton commented May 15, 2017

Copy link
Copy Markdown
MemberAuthor

@kennytm no the bootstrap won't use that Cargo until the next beta happens.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 15, 2017
@frewsxcv
Rollup merge ofrust-lang#41996- alexcrichton:more-retry, r=Mark-Sim…
7a07937
…ulacrum
appveyor: Wrap handle.exe download in a retry
Should help deal with spurious download failures.
@frewsxcvfrewsxcv mentioned this pull request May 15, 2017
Closed
@bors

bors commented May 15, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e5ec073 with merge 4565e1d...

@frewsxcv

frewsxcv commented May 15, 2017

Copy link
Copy Markdown
Contributor

Even with this change, AppVeyor still ran into an issue downloading handle.exe:

https://ci.appveyor.com/project/rust-lang/rust/build/1.0.3261/job/hgnbayocfa0rvkis

@alexcrichton
appveyor: Wrap handle.exe download in a retry
7644508
Should help deal with spurious download failures.
@alexcrichton

alexcrichton commented May 15, 2017

Copy link
Copy Markdown
MemberAuthor

@bors: r=Mark-Simulacrum

I've updated to a mirror

@bors

bors commented May 15, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 7644508 has been approved by Mark-Simulacrum

@bors

bors commented May 15, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7644508 with merge 0cbc437...

@bors

bors commented May 15, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@frewsxcv

frewsxcv commented May 15, 2017

Copy link
Copy Markdown
Contributor

that's gotta be unrelated, but what exactly is the error there?

@bors retry

@bors

bors commented May 15, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7644508 with merge 9f3ba8b...

bors added a commit that referenced this pull request May 15, 2017
@bors
Auto merge of#41996- alexcrichton:more-retry, r=Mark-Simulacrum
9f3ba8b
appveyor: Wrap handle.exe download in a retry
Should help deal with spurious download failures.
@Mark-Simulacrum

Mark-Simulacrum commented May 15, 2017

Copy link
Copy Markdown
Member

Yeah, I guess... rustc hung? It's odd.

@alexcrichton

alexcrichton commented May 15, 2017

Copy link
Copy Markdown
MemberAuthor

From the previous successful build:

[00:09:29] Compiling rustc v0.0.0 (file:///checkout/src/librustc)
[00:13:25] Compiling rustc_incremental v0.0.0 (file:///checkout/src/librustc_incremental)

Not sure how this jumped from 4 minutes to >30 in one run...

@bors

bors commented May 15, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented May 15, 2017

Copy link
Copy Markdown
MemberAuthor

@bors: retry

  • travis deployment problem?

@bors

bors commented May 16, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7644508 with merge ae33d99...

bors added a commit that referenced this pull request May 16, 2017
@bors
Auto merge of#41996- alexcrichton:more-retry, r=Mark-Simulacrum
ae33d99
appveyor: Wrap handle.exe download in a retry
Should help deal with spurious download failures.
@bors

bors commented May 16, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing ae33d99 to master...

@bors
bors merged commit 7644508 into rust-lang:masterMay 16, 2017
@alexcrichton
alexcrichton deleted the more-retry branch June 14, 2017 18:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brsonbrson

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@alexcrichton@rust-highfive@Mark-Simulacrum@bors@ishitatsuyuki@kennytm@frewsxcv@brson@carols10cents