Uh oh!
There was an error while loading. Please reload this page.
linkchecker: Add support for <base> tag - #41992
Merged
Merged
Conversation
Add support for the HTML <base> tag as used by mdBook so The Unstable Book can be checked. Also cleanup a few things: * Stop checking the name attribute. It should never have been used and mdBook has since been fixed not to use it. * Make sure we only check html files. * Remove a few unnecessary allocations. Finally, dead links in The Unstable Book have been fixed.
rust-highfive
commented
May 14, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
May 14, 2017
Member
@bors: r+ Awesome thanks! FWIW linkchecker was written in a time w/ only the makefiles so we couldn't use crates.io, but nowadays we could enhance this to actually depend on, for example, html5ever, and have real html parsing! I'm not sure if it's necessary, but something to consider at least. |
bors
commented
May 14, 2017
Collaborator
📌 Commit d4f20eb has been approved by |
bors
commented
May 14, 2017
Collaborator
⌛ Testing commit d4f20eb with merge 8ddecf2... |
bors
commented
May 14, 2017
Collaborator
💔 Test failed - status-appveyor |
Mark-Simulacrum
commented
May 14, 2017
Member
@bors retry |
alexcrichton
commented
May 14, 2017
Member
I've sent a PR to retry that HTTP request: #41996 |
bors
commented
May 14, 2017
Collaborator
⌛ Testing commit d4f20eb with merge fcc1a3c... |
bors
commented
May 14, 2017
Collaborator
💔 Test failed - status-appveyor |
Mark-Simulacrum
commented
May 14, 2017
Member
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 14, 2017
…chton linkchecker: Add support for <base> tag Add support for the HTML <base> tag as used by mdBook so The Unstable Book can be checked. Also cleanup a few things: * Stop checking the name attribute. It should never have been used and mdBook has since been fixed not to use it. * Make sure we only check html files. * Remove a few unnecessary allocations. Finally, dead links in The Unstable Book have been fixed.
bors
commented
May 15, 2017
Collaborator
bors added a commit
that referenced
this pull request
May 15, 2017
linkchecker: Add support for <base> tag Add support for the HTML <base> tag as used by mdBook so The Unstable Book can be checked. Also cleanup a few things: * Stop checking the name attribute. It should never have been used and mdBook has since been fixed not to use it. * Make sure we only check html files. * Remove a few unnecessary allocations. Finally, dead links in The Unstable Book have been fixed.
steveklabnik
commented
May 15, 2017
Contributor
Thanks for this! (I agree with @alexcrichton that we'll probably want to upgrade it even more in the future, but this is good for now) |
bors
commented
May 15, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the HTML tag as used by mdBook so The Unstable
Book can be checked.
Also cleanup a few things:
mdBook has since been fixed not to use it.
Finally, dead links in The Unstable Book have been fixed.