Uh oh!
There was an error while loading. Please reload this page.
Rollup of 4 pull requests - #41999
Closed
Mark-Simulacrum wants to merge 9 commits into
Closed
Conversation
The documentation for flt2dec doesn't match up with the actual implementation, so fix the documentation to align with reality. Presumably due to the mismatch, the formatting code for floats in std::fmt can use correspondingly shorter arrays in some places, so fix those places up as well. Fixesrust-lang#41304.
Add support for the HTML <base> tag as used by mdBook so The Unstable Book can be checked. Also cleanup a few things: * Stop checking the name attribute. It should never have been used and mdBook has since been fixed not to use it. * Make sure we only check html files. * Remove a few unnecessary allocations. Finally, dead links in The Unstable Book have been fixed.
Part of rust-lang#29378 . - In particular explains *why* we would use the builder instead of the free function. - Changes the parent-child explanation for a spawned-caller. - Add link to `io::Result` in `thread::Builder` - Corrects the `thread::Builder::spawn` documentation.
fix confusion about parts required for float formatting The documentation for flt2dec doesn't match up with the actual implementation, so fix the documentation to align with reality. Presumably due to the mismatch, the formatting code for floats in std::fmt can use correspondingly shorter arrays in some places, so fix those places up as well. Fixesrust-lang#41304.
…umeGomez [Doc] Explain why `thread::yield_now` could be used. Part of rust-lang#29378. r? @steveklabnik
…chton linkchecker: Add support for <base> tag Add support for the HTML <base> tag as used by mdBook so The Unstable Book can be checked. Also cleanup a few things: * Stop checking the name attribute. It should never have been used and mdBook has since been fixed not to use it. * Make sure we only check html files. * Remove a few unnecessary allocations. Finally, dead links in The Unstable Book have been fixed.
…eGomez [Doc] Implrove `thread::Builder`'s doc. Part of rust-lang#29378 . - Explains *why* we would use the builder instead ofthe free function. - Changes the parent-child explanation for a spawned-caller in `thread::Builder::spawn` - Adds a link to `io::Result` in `thread::Builder` - Corrects the return type doc in `thread::Builder::spawn` r? @rust-lang/docs
rust-highfive
commented
May 14, 2017
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
May 14, 2017
MemberAuthor
@bors r+ p=10 |
bors
commented
May 14, 2017
Collaborator
📌 Commit 215a753 has been approved by |
bors
commented
May 15, 2017
Collaborator
⌛ Testing commit 215a753 with merge e271ffe... |
bors
commented
May 15, 2017
Collaborator
💔 Test failed - status-appveyor |
Mark-Simulacrum
commented
May 15, 2017
MemberAuthor
@bors retry Though I seriously doubt this will work since it feels like the file is just.. not there somehow according to appveyor, but local testing shows it to be fine. So...? |
bors
commented
May 15, 2017
Collaborator
⌛ Testing commit 215a753 with merge 245849a... |
bors
commented
May 15, 2017
Collaborator
💔 Test failed - status-appveyor |
Member
"test both_git_and_path_specified has been running for over 60 seconds" #41859 is being |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thread::yield_nowcould be used. #41982, linkchecker: Add support for <base> tag #41992, [Doc] Implrovethread::Builder's doc. #41994