Skip to content

Implement requires_synchronized_create() for Redox - #42142

Merged
bors merged 1 commit into
rust-lang:masterfrom
ids1024:redox
May 25, 2017
Merged

Implement requires_synchronized_create() for Redox#42142
bors merged 1 commit into
rust-lang:masterfrom
ids1024:redox

Conversation

@ids1024

@ids1024ids1024 commented May 21, 2017

Copy link
Copy Markdown
Contributor

This was breaking the libstd build for Redox.

@ids1024
Implement requires_synchronized_create() for Redox
f4147e5
This was breaking the libstd build for Redox.
@rust-highfive

rust-highfive commented May 21, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@carols10centscarols10cents mentioned this pull request May 22, 2017
Closed
@carols10cents

carols10cents commented May 22, 2017

Copy link
Copy Markdown
Member

Looks like an intermittent travis problem; I've restarted the job.

We'll check in on this to make sure this PR gets through CI and gets reviewed!! Thank you!!

@carols10centscarols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2017
@aturon

aturon commented May 24, 2017

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented May 24, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit f4147e5 has been approved by aturon

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 24, 2017
@frewsxcv
Rollup merge ofrust-lang#42142- ids1024:redox, r=aturon
de0ab85
Implement requires_synchronized_create() for Redox
This was breaking the libstd build for Redox.
@frewsxcvfrewsxcv mentioned this pull request May 24, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 24, 2017
@frewsxcv
Rollup merge ofrust-lang#42142- ids1024:redox, r=aturon
e68d064
Implement requires_synchronized_create() for Redox
This was breaking the libstd build for Redox.
@frewsxcvfrewsxcv mentioned this pull request May 24, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42142- ids1024:redox, r=aturon
ee8dda4
Implement requires_synchronized_create() for Redox
This was breaking the libstd build for Redox.
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 24, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42142- ids1024:redox, r=aturon
6b9108e
Implement requires_synchronized_create() for Redox
This was breaking the libstd build for Redox.
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 24, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 24, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42142- ids1024:redox, r=aturon
4b41864
Implement requires_synchronized_create() for Redox
This was breaking the libstd build for Redox.
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 24, 2017
Closed
bors added a commit that referenced this pull request May 24, 2017
@bors
Auto merge of#42203- Mark-Simulacrum:rollup, r=Mark-Simulacrum
5f7b330
Rollup of 16 pull requests
- Successful merges: #41700, #41980, #42052, #42071, #42120, #42134, #42141, #42142, #42149, #42150, #42159, #42177, #42186, #42191, #42195, #42198
- Failed merges:
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 25, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42142- ids1024:redox, r=aturon
096de2e
Implement requires_synchronized_create() for Redox
This was breaking the libstd build for Redox.
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 25, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 25, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42142- ids1024:redox, r=aturon
81b8e09
Implement requires_synchronized_create() for Redox
This was breaking the libstd build for Redox.
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 25, 2017
Merged
bors added a commit that referenced this pull request May 25, 2017
@bors
Auto merge of#42212- Mark-Simulacrum:rollup, r=Mark-Simulacrum
cf747fc
Rollup of 15 pull requests
- Successful merges: #41980, #42071, #42120, #42134, #42141, #42142, #42149, #42150, #42159, #42177, #42186, #42191, #42195, #42198, #42211
- Failed merges:
@bors
bors merged commit f4147e5 into rust-lang:masterMay 25, 2017
@ids1024
ids1024 deleted the redox branch October 5, 2017 14:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturonaturon

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ids1024@rust-highfive@carols10cents@aturon@bors