Uh oh!
There was an error while loading. Please reload this page.
Rollup of 15 pull requests - #42212
Merged
Merged
Conversation
This is useful if parsing from stdin or a String and don't want to try and read in a module from another file. Instead we just leave a stub in the AST.
Not being an enum improves ergonomics, especially since NonEmpty could be Empty. It can still be iterable without an extra "done" bit by making the range have !(start <= end), which is even possible without changing the Step trait. Implements RFC 1980
Fixesrust-lang#42135 Found while fixing run-pass/range_inclusive test failure.
This was breaking the libstd build for Redox.
These files are licensed under a different license than the rest of the codebase. This causes potential issues and inconveniences. Relicense these files under the standard license. I hold original copyright on that code. Fixesrust-lang#36556
Also, add detection to treat such comments as tidy errors. We also remove the found_lib_feature code because it was just repeating the found_feature code. Originally it was intended to allow for gate-test lines for lib features, but apparently nobody missed it.
This brings verbosity even to invocation of cargo itself
See rust-lang#33525 for details.
Contains a fix for rust-lang/cargo#4081
[Doc] Add `'static` and `Send` constraints explanations to `thread::spawn` Part of rust-lang#29378. Explains why the constraints on the closure and its return value are `'static` and `Send`. Allows to tick of `thread::spawn` from the list of things to document in the `thread` module. r? @steveklabnik
Add an option to the parser to avoid parsing out of line modules This is useful if parsing from stdin or a String and don't want to try and read in a module from another file. Instead we just leave a stub in the AST.
remove "much" from unicode diagnostic The English seems slightly awkward to me, and it's unnecessary.
…turon Make RangeInclusive just a two-field struct Not being an enum improves ergonomics and consistency, especially since NonEmpty variant wasn't prevented from being empty. It can still be iterable without an extra "done" bit by making the range have !(start <= end), which is even possible without changing the Step trait. Implements merged rust-lang/rfcs#1980; tracking issue rust-lang#28237. This is definitely a breaking change to anything consuming `RangeInclusive` directly (not as an Iterator) or constructing it without using the sugar. Is there some change that would make sense before this so compilation failures could be compatibly fixed ahead of time? r? @aturon (as FCP proposer on the RFC)
Fix building std without backtrace feature, which was broken in ca8b754Fixesrust-lang#42139
Implement requires_synchronized_create() for Redox This was breaking the libstd build for Redox.
libstd/sync/mpsc: relicense under rust license These files are licensed under a different license than the rest of the codebase. This causes potential issues and inconveniences. Relicense these files under the standard license. I hold original copyright on that code. Fixesrust-lang#36556
…ages, r=Mark-Simulacrum Change error count messages See rust-lang#33525 for details. r? @Mark-Simulacrum
Document drop more. Adds two examples to Drop and describes the recursive drop on types that contain fields.
Remove some needless // gate-test- comments Also, add detection to treat such comments as tidy errors. We also remove the found_lib_feature code because it was just repeating the found_feature code. Originally it was intended to allow for gate-test lines for lib features, but apparently nobody missed it.
…=alexcrichton bootstrap: Make bootstrap verbose if requested Fixes: rust-lang#42099
…imulacrum Update Cargo submodule Contains a fix for rust-lang/cargo#4081
…labnik fix broken link to nomicon in Unsize docs Add a missing link that is currently broken in the docs (see the last sentence of https://doc.rust-lang.org/std/marker/trait.Unsize.html)
…isdreavus Add missing urls for OsStr docs r? @rust-lang/docs
…rk-Simulacrum Hack around abysmally slow llvm clones r? @Mark-Simulacrum (don't r+ yet, let's see what travis says)
rust-highfive
commented
May 25, 2017
Contributor
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
May 25, 2017
MemberAuthor
@bors r+ p=10 |
bors
commented
May 25, 2017
Collaborator
📌 Commit d429b49 has been approved by |
Mark-Simulacrum
commented
May 25, 2017
MemberAuthor
Or, I guess, to make it land... @bors p=101 |
bors
commented
May 25, 2017
Collaborator
bors added a commit
that referenced
this pull request
May 25, 2017
bors
commented
May 25, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This was referenced May 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'staticandSendconstraints explanations tothread::spawn#41980, Add an option to the parser to avoid parsing out of line modules #42071, remove "much" from unicode diagnostic #42120, Make RangeInclusive just a two-field struct #42134, Fix building std without backtrace feature, which was broken in ca8b754 #42141, Implement requires_synchronized_create() for Redox #42142, libstd/sync/mpsc: relicense under rust license #42149, Change error count messages #42150, Document drop more. #42159, Remove some needless // gate-test- comments #42177, bootstrap: Make bootstrap verbose if requested #42186, Update Cargo submodule #42191, fix broken link to nomicon in Unsize docs #42195, Add missing urls for OsStr docs #42198, Hack around abysmally slow llvm clones #42211