Skip to content

Deprecate range-specific step_by - #42310

Merged
bors merged 3 commits into
rust-lang:masterfrom
scottmcm:deprecate-range-stepby
Jun 3, 2017
Merged

Deprecate range-specific step_by#42310
bors merged 3 commits into
rust-lang:masterfrom
scottmcm:deprecate-range-stepby

Conversation

@scottmcm

Copy link
Copy Markdown
Member

Deprecation attributes and test updates only.

Was replaced by an any-iterator version in #41439

Last follow-up (this release) to #42110 (comment)

r? @alexcrichton

@frewsxcvfrewsxcv added the T-libs-api [DEPRECATED; DO NOT USE] label May 30, 2017
@alexcrichton

Copy link
Copy Markdown
Member

Looks great to me, thanks! I think there's one remaining CI error though?

[01:03:21] error: use of deprecated item: replaced by `Iterator::step_by`
[01:03:21] --> /checkout/src/libcollections/../libcollections/tests/vec_deque.rs:513:21
[01:03:21] |
[01:03:21] 513 | let seq = (0..).step_by(2).take(256);
[01:03:21] | ^^^^^^^
[01:03:21] |
[01:03:21] = note: #[deny(deprecated)] implied by #[deny(warnings)]
[01:03:21] note: lint level defined here
[01:03:21] --> /checkout/src/libcollections/../libcollections/tests/lib.rs:11:9
[01:03:21] |
[01:03:21] 11 | #![deny(warnings)]
[01:03:21] | ^^^^^^^^
[01:03:21] [01:03:21] error: aborting due to previous error(s)
[01:03:21] [01:03:21] error: Could not compile `collections`.

@scottmcm

Copy link
Copy Markdown
MemberAuthor

Oops, I missed a step. Closing temporarily; will re-open after #42315.

Changed all the tests except test_range_step to use Iterator::step_by.
Only exposed as DeprecatedStepBy (as of PR 41439)
@scottmcm

Copy link
Copy Markdown
MemberAuthor

Reopening as #42315 has landed, allowing some more tests to be moved over to Iterator::step_by.

@scottmcmscottmcm reopened this Jun 1, 2017
@scottmcm
scottmcmforce-pushed the deprecate-range-stepby branch from 9430117 to 15dff84CompareJune 1, 2017 06:10
@alexcrichtonalexcrichton added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2017
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

Thanks @scottmcm!

@bors

bors commented Jun 1, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 15dff84 has been approved by alexcrichton

@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 1, 2017
…alexcrichton
Deprecate range-specific `step_by`
Deprecation attributes and test updates only.
Was replaced by an any-iterator version in rust-lang#41439
Last follow-up (this release) to rust-lang#42110 (comment)
r? @alexcrichton
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 1, 2017
…alexcrichton
Deprecate range-specific `step_by`
Deprecation attributes and test updates only.
Was replaced by an any-iterator version in rust-lang#41439
Last follow-up (this release) to rust-lang#42110 (comment)
r? @alexcrichton
@frewsxcvfrewsxcv mentioned this pull request Jun 2, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 2, 2017
…alexcrichton
Deprecate range-specific `step_by`
Deprecation attributes and test updates only.
Was replaced by an any-iterator version in rust-lang#41439
Last follow-up (this release) to rust-lang#42110 (comment)
r? @alexcrichton
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 2, 2017
…alexcrichton
Deprecate range-specific `step_by`
Deprecation attributes and test updates only.
Was replaced by an any-iterator version in rust-lang#41439
Last follow-up (this release) to rust-lang#42110 (comment)
r? @alexcrichton
bors added a commit that referenced this pull request Jun 2, 2017
Rollup of 10 pull requests
- Successful merges: #41981, #42225, #42310, #42319, #42335, #42343, #42355, #42360, #42370, #42372
- Failed merges:
bors added a commit that referenced this pull request Jun 2, 2017
Rollup of 10 pull requests
- Successful merges: #41981, #42225, #42310, #42319, #42335, #42343, #42355, #42360, #42370, #42372
- Failed merges:
@bors
bors merged commit 15dff84 into rust-lang:masterJun 3, 2017
@scottmcm
scottmcm deleted the deprecate-range-stepby branch June 3, 2017 06:01
bors added a commit that referenced this pull request Jul 4, 2017
Delete deprecated & unstable range-specific `step_by`
Using the new one is annoying while this one exists, since the inherent method hides the one on iterator.
Tracking issue: #27741
Replacement: #41439
Deprecation: #42310 for 1.19
Fixes#41477
bors added a commit that referenced this pull request Jul 8, 2017
Implement O(1)-time Iterator::nth for Range*, and slim the Step trait
Fixes#43064.
Fixes part of #39975.
Fixes items 1 <s>and 3</s> of #42168.
CC #27741.
I think #42310 and #43012 should not have landed without the `nth` part of this PR, but oh well.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@scottmcm@alexcrichton@bors@Mark-Simulacrum@frewsxcv