Skip to content

Rollup of 11 pull requests - #42377

Closed
frewsxcv wants to merge 9 commits into
rust-lang:masterfrom
frewsxcv:rollup
Closed

Rollup of 11 pull requests#42377
frewsxcv wants to merge 9 commits into
rust-lang:masterfrom
frewsxcv:rollup

Conversation

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv

Copy link
Copy Markdown
ContributorAuthor

@bors r+ p=10

@bors

bors commented Jun 2, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit fe75dd9 has been approved by frewsxcv

@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r-

#42354 will fail on bots (I just r--ed it).

@bors

bors commented Jun 2, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #42128) made this pull request unmergeable. Please resolve the merge conflicts.

cuviperand others added 4 commits June 2, 2017 09:27
This option forwards to each `cargo test` invocation, and applies the
same logic across all test steps to keep going after failures. At the
end, a brief summary line reports how many commands failed, if any.
Note that if a test program fails to even start at all, or if an
auxiliary build command related to testing fails, these are still left
to stop everything right away.
Fixesrust-lang#40219.
This was added in rust-lang#38072 but I can't recall why and AFAIK Cargo already handles
this. This was discovered through rust-lang#42146 where passing duplicate flags was
causing problems.
@shepmastershepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 2, 2017
…umeGomez
Update various book repos for the next release.
…=alexcrichton
Reduce verbosity of build logs
This does two separate things.
- Sets sccache logging to warn instead of info.
- Makes tests when running for a given PR (not on auto branch) quiet. (cc @eddyb)
r? @alexcrichton
rustbuild: Add `./x.py test --no-fail-fast`
This option forwards to each `cargo test` invocation, and applies the
same logic across all test steps to keep going after failures. At the
end, a brief summary line reports how many commands failed, if any.
Note that if a test program fails to even start at all, or if an
auxiliary build command related to testing fails, these are still left
to stop everything right away.
Fixesrust-lang#40219.
…rk-Simulacrum
rustbuild: Remove RUSTFLAGS logic in rustc shim
This was added in rust-lang#38072 but I can't recall why and AFAIK Cargo already handles
this. This was discovered through rust-lang#42146 where passing duplicate flags was
causing problems.
@frewsxcvfrewsxcv closed this Jun 3, 2017
@CentrilCentril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@frewsxcv@rust-highfive@bors@Mark-Simulacrum@brson@shepmaster@Centril@steveklabnik@cuviper@alexcrichton