Uh oh!
There was an error while loading. Please reload this page.
rustbuild: Add ./x.py test --no-fail-fast - #42363
Merged
Merged
Conversation
rust-highfive
commented
Jun 1, 2017
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Jun 1, 2017
Member
alexcrichton
commented
Jun 1, 2017
Member
Thanks! I've personally held off on doing this in the past b/c I was hoping to add a general "keep going" flag but that'd require keeping track of dependencies between stages and likely changing everything to return In other words, looks great! @bors: r+ |
bors
commented
Jun 1, 2017
Collaborator
📌 Commit 4880ae8 has been approved by |
Mark-Simulacrum
commented
Jun 1, 2017
Member
@bors rollup |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 1, 2017
rustbuild: Add `./x.py test --no-fail-fast` This option forwards to each `cargo test` invocation, and applies the same logic across all test steps to keep going after failures. At the end, a brief summary line reports how many commands failed, if any. Note that if a test program fails to even start at all, or if an auxiliary build command related to testing fails, these are still left to stop everything right away. Fixesrust-lang#40219.
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 2, 2017
rustbuild: Add `./x.py test --no-fail-fast` This option forwards to each `cargo test` invocation, and applies the same logic across all test steps to keep going after failures. At the end, a brief summary line reports how many commands failed, if any. Note that if a test program fails to even start at all, or if an auxiliary build command related to testing fails, these are still left to stop everything right away. Fixesrust-lang#40219.
bors
commented
Jun 2, 2017
Collaborator
☔ The latest upstream changes (presumably #42128) made this pull request unmergeable. Please resolve the merge conflicts. |
This option forwards to each `cargo test` invocation, and applies the same logic across all test steps to keep going after failures. At the end, a brief summary line reports how many commands failed, if any. Note that if a test program fails to even start at all, or if an auxiliary build command related to testing fails, these are still left to stop everything right away. Fixesrust-lang#40219.
cuviper
commented
Jun 2, 2017
MemberAuthor
Rebased. I had to add a |
Mark-Simulacrum
commented
Jun 2, 2017
Member
@bors r=alexcrichton |
bors
commented
Jun 2, 2017
Collaborator
📌 Commit 617aea4 has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Jun 3, 2017
rustbuild: Add `./x.py test --no-fail-fast` This option forwards to each `cargo test` invocation, and applies the same logic across all test steps to keep going after failures. At the end, a brief summary line reports how many commands failed, if any. Note that if a test program fails to even start at all, or if an auxiliary build command related to testing fails, these are still left to stop everything right away. Fixesrust-lang#40219.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Jun 3, 2017
rustbuild: Add `./x.py test --no-fail-fast` This option forwards to each `cargo test` invocation, and applies the same logic across all test steps to keep going after failures. At the end, a brief summary line reports how many commands failed, if any. Note that if a test program fails to even start at all, or if an auxiliary build command related to testing fails, these are still left to stop everything right away. Fixesrust-lang#40219.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option forwards to each
cargo testinvocation, and applies thesame logic across all test steps to keep going after failures. At the
end, a brief summary line reports how many commands failed, if any.
Note that if a test program fails to even start at all, or if an
auxiliary build command related to testing fails, these are still left
to stop everything right away.
Fixes#40219.