Fix NaN handling in is_sign_negative/positive by nagisa · Pull Request #42431 · rust-lang/rust

nagisa · 2017-06-04T18:47:34Z

This would be my proposed fix for the #42425 provided we decide it is indeed a problem.

Note this would technically be a breaking change to a stable API. We might want to consider deprecating these methods and adding new ones.

rust-highfive · 2017-06-04T18:47:44Z

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

retep998 · 2017-06-04T19:09:35Z

I'm more surprised that it returns true for "-0.0, NaNs with negative sign, and negative infinity". I would not expect those cases to have a positive sign.

natboehm · 2017-06-05T15:15:23Z

[01:11:11] failures:
[01:11:11] f32::tests::test_is_sign_positive
[01:11:11] f32::tests::test_nan
[01:11:11] f64::tests::test_is_sign_positive
[01:11:11] f64::tests::test_nan

It looks like some tests are failing.

nagisa · 2017-06-05T15:41:07Z

This is not supposed to be in a landable state until we reach some concensus anyway.

arielb1 · 2017-06-20T20:26:20Z

What's the status of this @nagisa? Just checking in to make sure it isn't getting lost.

alexcrichton · 2017-06-20T22:33:40Z

Discussed during libs triage the conclusion was that this seems good to land! @nagisa want to fix up the tests and I'll r+?

alexcrichton · 2017-06-22T14:47:49Z

Looks like there's some Travis errors?

[01:11:14] failures:
[01:11:14] [01:11:14] ---- f32.rs - f32::f32::is_sign_negative (line 388) stdout ----
[01:11:14] thread 'rustc' panicked at 'test executable failed:
[01:11:14] [01:11:14] thread 'main' panicked at 'assertion failed: !nan.is_sign_positive() && !nan.is_sign_negative()', <anon>:13
[01:11:14] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:11:14] [01:11:14] ', /checkout/src/librustdoc/test.rs:318
[01:11:14] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:11:14] [01:11:14] ---- f32.rs - f32::f32::is_sign_positive (line 369) stdout ----
[01:11:14] thread 'rustc' panicked at 'test executable failed:
[01:11:14] [01:11:14] thread 'main' panicked at 'assertion failed: !nan.is_sign_positive() && !nan.is_sign_negative()', <anon>:13
[01:11:14] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:11:14] [01:11:14] ', /checkout/src/librustdoc/test.rs:318
[01:11:14] [01:11:14] ---- f64.rs - f64::f64::is_sign_negative (line 332) stdout ----
[01:11:14] thread 'rustc' panicked at 'test executable failed:
[01:11:14] [01:11:14] thread 'main' panicked at 'assertion failed: !nan.is_sign_positive() && !nan.is_sign_negative()', <anon>:14
[01:11:14] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:11:14] [01:11:14] ', /checkout/src/librustdoc/test.rs:318
[01:11:14] [01:11:14] ---- f64.rs - f64::f64::is_sign_positive (line 307) stdout ----
[01:11:14] thread 'rustc' panicked at 'test executable failed:
[01:11:14] [01:11:14] thread 'main' panicked at 'assertion failed: !nan.is_sign_positive() && !nan.is_sign_negative()', <anon>:14
[01:11:14] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:11:14] [01:11:14] ', /checkout/src/librustdoc/test.rs:318
[01:11:14] [01:11:14] [01:11:14] failures:
[01:11:14] f32.rs - f32::f32::is_sign_negative (line 388)
[01:11:14] f32.rs - f32::f32::is_sign_positive (line 369)
[01:11:14] f64.rs - f64::f64::is_sign_negative (line 332)
[01:11:14] f64.rs - f64::f64::is_sign_positive (line 307)
[01:11:14] [01:11:14] test result: FAILED. 820 passed; 4 failed; 22 ignored; 0 measured; 0 filtered out

See rust-lang#42425

arielb1 · 2017-06-27T20:47:44Z

@nagisa is this ready for review?

nagisa · 2017-06-27T20:50:44Z

@alexcrichton tests pass.

alexcrichton · 2017-06-27T22:04:15Z

@bors: r+

bors · 2017-06-27T22:04:16Z

📌 Commit 3b9fe77 has been approved by alexcrichton

alexcrichton · 2017-06-27T22:04:20Z

@bors: r+

bors · 2017-06-27T22:04:21Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: [beta] backports #42927

bors · 2017-06-27T22:04:21Z

📌 Commit 3b9fe77 has been approved by alexcrichton

bors · 2017-06-28T03:41:27Z

⌛ Testing commit 3b9fe77 with merge 88c3242...

Fix NaN handling in is_sign_negative/positive This would be my proposed fix for the #42425 provided we decide it is indeed a problem. Note this would technically be a breaking change to a stable API. We might want to consider deprecating these methods and adding new ones.

bors · 2017-06-28T06:19:18Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 88c3242 to master...

rust-highfive assigned brson Jun 4, 2017

kennytm mentioned this pull request Jun 4, 2017
Re-implement float min/max in rust #42430
Merged

retep998 reviewed Jun 4, 2017
View reviewed changes

nagisa force-pushed the core-float-2 branch 2 times, most recently from 8c1ee68 to 0853ec5Compare June 4, 2017 23:29

carols10cents added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 5, 2017

arielb1 added T-libs-api [DEPRECATED; DO NOT USE] S-waiting-on-team and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 6, 2017

brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 6, 2017

nagisa force-pushed the core-float-2 branch from 0853ec5 to f1d1107Compare June 21, 2017 15:27

alexcrichton added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-team labels Jun 22, 2017

nagisa force-pushed the core-float-2 branch from f1d1107 to 2626668Compare June 22, 2017 15:07

Fix NaN handling in is_sign_negative/positive
3b9fe77
See rust-lang#42425

nagisa force-pushed the core-float-2 branch from 2626668 to 3b9fe77Compare June 22, 2017 20:12

nagisa added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2017

alexcrichton closed this Jun 27, 2017

alexcrichton reopened this Jun 27, 2017

bors merged commit 3b9fe77 into rust-lang:masterJun 28, 2017

cuviper mentioned this pull request Jun 29, 2017
assertion failed: !nan.is_sign_positive() && !nan.is_sign_negative() rust-num/num#312
Closed

PlasmaPower mentioned this pull request Jul 8, 2017
Derive ToPrimitive for enums rust-num/num#314
Merged

kennytm mentioned this pull request Aug 3, 2017
Updated release notes for 1.20 #43627
Merged

arielb1 mentioned this pull request Aug 5, 2017
num-traits-0.1.39 beta regression #43674
Closed

hanna-kruppe mentioned this pull request Nov 20, 2017
IEEE754 non-conformance: is_sign_negative does not apply on NANs #42425
Closed

tspiteri mentioned this pull request Dec 29, 2017
NaN behaviour of is_sign_positive and is_sign_negative is not like for primitive types VoidStarKat/half-rs#3
Closed

Uh oh!

Uh oh!

Conversation

nagisa commented Jun 4, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jun 4, 2017

Uh oh!

retep998Jun 4, 2017

Choose a reason for hiding this comment

Uh oh!

ThiezJun 4, 2017

Choose a reason for hiding this comment

Uh oh!

natboehm commented Jun 5, 2017

Uh oh!

nagisa commented Jun 5, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arielb1 commented Jun 20, 2017

Uh oh!

alexcrichton commented Jun 20, 2017

Uh oh!

alexcrichton commented Jun 22, 2017

Uh oh!

arielb1 commented Jun 27, 2017

Uh oh!

nagisa commented Jun 27, 2017

Uh oh!

alexcrichton commented Jun 27, 2017

Uh oh!

bors commented Jun 27, 2017

Uh oh!

alexcrichton commented Jun 27, 2017

Uh oh!

bors commented Jun 27, 2017

Uh oh!

bors commented Jun 27, 2017

Uh oh!

bors commented Jun 28, 2017

Uh oh!

bors commented Jun 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

nagisa commented Jun 4, 2017•
edited
Loading

nagisa commented Jun 5, 2017•
edited
Loading