Create more error codes by GuillaumeGomez · Pull Request #42519 · rust-lang/rust

GuillaumeGomez · 2017-06-07T22:15:37Z

rust-highfive · 2017-06-07T22:15:47Z

(rust_highfive has picked a reviewer for you, use r? to override)

aidanhs · 2017-06-08T00:12:19Z

[00:46:17] error[E0600]: cannot apply unary operator `!` to type `char`
[00:46:17] --> <anon>:3:1
[00:46:17] |
[00:46:17] 3 | assert!(c, 'V');
[00:46:17] | ^^^^^^^^^^^^^^^^
[00:46:17] |
[00:46:17] = note: this error originates in a macro outside of the current crate

Presumably meant to be assert_eq?

GuillaumeGomez · 2017-06-08T13:17:53Z

Absolutely!

GuillaumeGomez · 2017-06-09T16:59:35Z

Fixed btw.

Susurrus · 2017-06-09T17:15:24Z

Should read: "Only primitive types can be cast into each other"

Susurrus · 2017-06-09T17:16:34Z

Same as above.
I'm thinking the first line should read more like "Casting between non-primitive types" or something instead of just saying "invalid cast" and then having to explain every time that a valid cast is just between primitives.

Susurrus · 2017-06-09T17:16:48Z

"DST" instead of "They" at the start to be more clear.

Susurrus · 2017-06-09T17:17:01Z

Get rid of "So in order"

Susurrus · 2017-06-09T17:18:58Z

Any way to remove "non-scalar" from this? Your expanded error descriptions you added above use the term "primitive types", can that be used everywhere for all these errors instead of "non-scalar"? I never see "non-scalar" in any docs anywhere.

Hum, do you have a better formulation?

"non-primitive cast"? Primitive is a word people will/should be exposed to when using rust. I don't think "non-scalar" appears much in the docs (though I haven't searched, but I've never seen it).

Fine by me!

GuillaumeGomez · 2017-06-09T20:21:56Z

Updated.

Susurrus · 2017-06-09T20:24:13Z

This reads awkwardly. I suggest "was attempted on a type other than u8".
This error does bring up the question of why are only u8s castable to chars? I thought a char in rust was 4 bytes?

I think it comes straight from the C language. In C, char are 8 bits and supposed to represent ascii characters.

Susurrus · 2017-06-09T20:24:45Z

should be "can be casted"

Susurrus · 2017-06-09T20:25:31Z

Maybe instead be more clear what simple means: "Thin pointers are purely a reference to a memory address"

Susurrus · 2017-06-09T20:27:24Z

This brings up the question of why? What extra information is required to be stored that makes a fat pointer a necessity. Adding a sentence or clarifying why just a pure memory address would be useful here (I'm not even actually sure of why fat pointers are necessary).

So, the explanation for you too (so nice of me haha 😉 ). Let's take a slice: you need in addition of the memory address, the size of the slice.
That's actually a good explanation, I'll add it. :)

GuillaumeGomez · 2017-06-09T20:40:50Z

Updated.

Susurrus · 2017-06-11T02:42:42Z

"can be casted"

GuillaumeGomez · 2017-06-11T10:31:46Z

Updated.

Susurrus · 2017-06-11T15:49:56Z

There are a few instances of "casted" used here when I think the past tense of "cast" is actually just "cast".

Damn irregular verbs! :p

GuillaumeGomez · 2017-06-11T16:50:59Z

Fixed the verbing error.

bors · 2017-06-12T02:21:06Z

☔ The latest upstream changes (presumably #42585) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2017-06-12T16:58:47Z

And re-updated. cc @Susurrus

Susurrus · 2017-06-12T17:00:55Z

LGTM

GuillaumeGomez · 2017-06-12T17:04:27Z

@bors: r+

bors · 2017-06-12T17:04:28Z

📌 Commit 851fbbc has been approved by GuillaumeGomez

frewsxcv · 2017-06-12T17:49:56Z

@bors r-

who is the reviewer?

GuillaumeGomez · 2017-06-12T19:09:46Z

r? @frewsxcv

frewsxcv · 2017-06-13T03:31:31Z

I don't know if "dynamically sized types" needs to be capitalized here, but not a big deal

I agree, it shouldn't be capitalized.

It was to make easier the understanding of DST.

Ok removed.

frewsxcv · 2017-06-13T03:36:57Z

As long as this is the catch-all error message for invalid casting, I'm slightly leaning towards listing all the different casting rules. Maybe we could just link to the book? Other error messages seem to link to the book/reference

GuillaumeGomez · 2017-06-15T08:41:52Z

So, I added an url to the rust reference to every cast rules in all long error explanation. Do you think I need to update something else?

QuietMisdreavus · 2017-06-15T18:54:29Z

I still think it would be better to rephrase the explain text for E0606 to state something like "incompatible cast" instead of talking about "non-primitive types". Especially now that it's linking to the list of "valid casts", we can just call it "invalid" or "incompatible" or something like that.

bors · 2017-06-16T03:31:18Z

☔ The latest upstream changes (presumably #42568) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2017-06-24T19:28:54Z

I slightly updated the long error explanation. Does it seem good like this?

QuietMisdreavus · 2017-06-24T20:59:11Z

It looks like the links to the reference got taken out in the last update? I'd rather leave those in.

GuillaumeGomez · 2017-06-25T07:34:08Z

Updated.

QuietMisdreavus · 2017-06-26T18:02:20Z

Travis looks stuck on one builder, but the ALLOW_PR build passed, so that's good enough for me.

@bors r+

Thanks so much!

bors · 2017-06-26T18:02:21Z

📌 Commit bcf0d60 has been approved by QuietMisdreavus

frewsxcv · 2017-06-27T03:32:21Z

@bors rollup

@Susurrus

…des, r=QuietMisdreavus Create more error codes Fixesrust-lang#31174. Part of rust-lang#42229. cc @Susurrus

Rollup of 5 pull requests - Successful merges: #42519, #42871, #42874, #42905, #42917 - Failed merges:

@Susurrus

Remove err methods To be merged after #42519. cc @Susurrus @QuietMisdreavus

rust-highfive assigned pnkfelix Jun 7, 2017

aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2017

GuillaumeGomez force-pushed the create-more-error-codes branch from 9bedfa8 to 341f827Compare June 8, 2017 13:17

Susurrus suggested changes Jun 9, 2017
View reviewed changes

GuillaumeGomez force-pushed the create-more-error-codes branch from 341f827 to c1791baCompare June 9, 2017 20:21

Susurrus suggested changes Jun 9, 2017
View reviewed changes

GuillaumeGomez force-pushed the create-more-error-codes branch from c1791ba to 69cdf76Compare June 9, 2017 20:40

GuillaumeGomez force-pushed the create-more-error-codes branch 3 times, most recently from e18afb3 to c70c37aCompare June 10, 2017 19:23

Susurrus suggested changes Jun 11, 2017
View reviewed changes

Comment threadsrc/librustc_typeck/diagnostics.rs Outdated
SusurrusJun 11, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"can be casted"

GuillaumeGomez force-pushed the create-more-error-codes branch from c70c37a to b0016caCompare June 11, 2017 10:31

Susurrus suggested changes Jun 11, 2017
View reviewed changes

GuillaumeGomez force-pushed the create-more-error-codes branch from b0016ca to b9804adCompare June 11, 2017 16:50

GuillaumeGomez force-pushed the create-more-error-codes branch from b9804ad to 851fbbcCompare June 12, 2017 16:58

frewsxcv reviewed Jun 13, 2017
View reviewed changes

GuillaumeGomez closed this Jun 15, 2017

GuillaumeGomez reopened this Jun 15, 2017

arielb1 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2017

GuillaumeGomez added 6 commits June 24, 2017 21:25

Add E0604
d5977df

Add E0605
0e4b8ff

Add E0606
30effc1

Add E0607
7b8c6a2

wording improvement
deb1eb6

Use new macro instead
9137153

GuillaumeGomez force-pushed the create-more-error-codes branch from 7c12bbb to 9137153Compare June 24, 2017 19:28

GuillaumeGomez mentioned this pull request Jun 24, 2017
Remove err methods #42887
Merged

Add reference link
bcf0d60

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 27, 2017
Rollup merge ofrust-lang#42519- GuillaumeGomez:create-more-error-co…
b2c3130
…des, r=QuietMisdreavus Create more error codes Fixesrust-lang#31174. Part of rust-lang#42229. cc @Susurrus

frewsxcv mentioned this pull request Jun 27, 2017
Rollup of 5 pull requests #42922
Merged

bors added a commit that referenced this pull request Jun 27, 2017
Auto merge of#42922- frewsxcv:rollup, r=frewsxcv
f590a44
Rollup of 5 pull requests - Successful merges: #42519, #42871, #42874, #42905, #42917 - Failed merges:

bors merged commit bcf0d60 into rust-lang:masterJun 27, 2017

GuillaumeGomez deleted the create-more-error-codes branch June 27, 2017 07:42

dwrensha mentioned this pull request Jun 28, 2017
update tests for new error message rust-lang/miri#221
Merged

bors added a commit that referenced this pull request Jun 29, 2017
Auto merge of#42887- GuillaumeGomez:remove-err-methods, r=nikomatsakis
d0e0f53
Remove err methods To be merged after #42519. cc @Susurrus @QuietMisdreavus

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Jun 7, 2017

Uh oh!

rust-highfive commented Jun 7, 2017

Uh oh!

aidanhs commented Jun 8, 2017

Uh oh!

GuillaumeGomez commented Jun 8, 2017

Uh oh!

GuillaumeGomez commented Jun 9, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Jun 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Jun 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Jun 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Jun 11, 2017

Uh oh!

bors commented Jun 12, 2017

Uh oh!

GuillaumeGomez commented Jun 12, 2017

Uh oh!

Susurrus commented Jun 12, 2017

Uh oh!

GuillaumeGomez commented Jun 12, 2017

Uh oh!

bors commented Jun 12, 2017

Uh oh!

frewsxcv commented Jun 12, 2017

Uh oh!

GuillaumeGomez commented Jun 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Jun 9, 2017•
edited
Loading