E0608

[GuillaumeGomez]

Part of #42229.

cc @Susurrus

[rust-highfive]

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

[Susurrus]

This isn't really getting an index, at least in the eyes of the user, is it? It's more trying to index into the type. Maybe rephrase this as "An attempt to index into a type which doesn't implement the Index trait was performed." Maybe it actually makes sense to use std::ops::Index instead of Index as well.

[Susurrus]

I would use "cannot index into a value of type {}" instead

[GuillaumeGomez]

That's not the into the problem, that's the index. I think switching the message to this would make the error lose its meaning.

[Susurrus]

This is separate than the Into trait stuff. I've always heard indexing described as being into something, like you "index into an array", you don't "index an array". The latter sounds weird to me. With the current PR you use "index into" in the detailed explanation, but the short error title is still "index a value". This should at least be consistent.

[GuillaumeGomez]

Ok, let me rewrite this then.

[GuillaumeGomez]

Updated.

[Susurrus]

This is separate than the Into trait stuff. I've always heard indexing described as being into something, like you "index into an array", you don't "index an array". The latter sounds weird to me. With the current PR you use "index into" in the detailed explanation, but the short error title is still "index a value". This should at least be consistent.

[GuillaumeGomez]

Updated.

[bors]

☔ The latest upstream changes (presumably #42585) made this pull request unmergeable. Please resolve the merge conflicts.

[GuillaumeGomez]

Updated as well. cc @Susurrus

[Susurrus]

Instead "To be able to index into a type it needs to implement ..."

[GuillaumeGomez]

And updated.

cc @frewsxcv@QuietMisdreavus

[QuietMisdreavus]

Looks good!

@bors r+

[bors]

📌 Commit b6e9ed1 has been approved by QuietMisdreavus

[bors]

⌛ Testing commit b6e9ed1 with merge a311496...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing a311496 to master...