Skip to content

Update docs for fmt::write. - #42831

Merged
bors merged 1 commit into
rust-lang:masterfrom
rthomas:master
Jun 29, 2017
Merged

Update docs for fmt::write.#42831
bors merged 1 commit into
rust-lang:masterfrom
rthomas:master

Conversation

@rthomas

@rthomasrthomas commented Jun 22, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

#29355

I reworded it slightly to make it more clear that the function only take
two arguments - the output and the Arguments struct that can be
generated from the format_args! macro.

r? @steveklabnik

@rthomas
Update docs for fmt::write.
b9a44fc
I reworded it slightly to make it more clear that the function only take
two arguments - the output and the Arguments struct that can be
generated from the format_args! macro.
r? @steveklabnik
@rust-highfive

rust-highfive commented Jun 22, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@shepmaster

shepmaster commented Jun 23, 2017

Copy link
Copy Markdown
Member

Thanks @rthomas, we'll get @steveklabnik (or someone) to review this and your other PRs soon!

@shepmastershepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2017
@QuietMisdreavus

QuietMisdreavus commented Jun 27, 2017

Copy link
Copy Markdown
Contributor

@bors r+

Thanks!

@bors

bors commented Jun 27, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit b9a44fc has been approved by QuietMisdreavus

@arielb1

arielb1 commented Jun 27, 2017

Copy link
Copy Markdown
Contributor

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 28, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42831- rthomas:master, r=QuietMisdreavus
211e09c
Update docs for fmt::write.
rust-lang#29355
I reworded it slightly to make it more clear that the function only take
two arguments - the output and the Arguments struct that can be
generated from the format_args! macro.
r? @steveklabnik
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jun 28, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 29, 2017
@frewsxcv
Rollup merge ofrust-lang#42831- rthomas:master, r=QuietMisdreavus
b01447f
Update docs for fmt::write.
rust-lang#29355
I reworded it slightly to make it more clear that the function only take
two arguments - the output and the Arguments struct that can be
generated from the format_args! macro.
r? @steveklabnik
@frewsxcvfrewsxcv mentioned this pull request Jun 29, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Jun 29, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#42831- rthomas:master, r=QuietMisdreavus
8b32c51
Update docs for fmt::write.
rust-lang#29355
I reworded it slightly to make it more clear that the function only take
two arguments - the output and the Arguments struct that can be
generated from the format_args! macro.
r? @steveklabnik
@arielb1arielb1 mentioned this pull request Jun 29, 2017
Merged
bors added a commit that referenced this pull request Jun 29, 2017
@bors
Auto merge of#42964- arielb1:rollup, r=arielb1
7acce37
Rollup of 12 pull requests
- Successful merges: #42219, #42831, #42832, #42884, #42886, #42901, #42919, #42920, #42946, #42953, #42955, #42958
- Failed merges:
@bors
bors merged commit b9a44fc into rust-lang:masterJun 29, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rthomas@rust-highfive@shepmaster@QuietMisdreavus@bors@arielb1@steveklabnik