Skip to content

Move global vars changing tests into run-pass - #42884

Merged
bors merged 1 commit into
rust-lang:masterfrom
stepancheg:set-env-run-pass
Jun 29, 2017
Merged

Move global vars changing tests into run-pass#42884
bors merged 1 commit into
rust-lang:masterfrom
stepancheg:set-env-run-pass

Conversation

@stepancheg

@stepanchegstepancheg commented Jun 24, 2017

Copy link
Copy Markdown
Contributor

Should fix race #42795

@rust-highfive

rust-highfive commented Jun 24, 2017

Copy link
Copy Markdown
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@stepancheg

stepancheg commented Jun 24, 2017

Copy link
Copy Markdown
ContributorAuthor

r? @alexcrichton

@alexcrichton

alexcrichton commented Jun 24, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Jun 24, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 45af6ee has been approved by alexcrichton

@bors

bors commented Jun 24, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 45af6ee with merge f62cae43700e171de4fd6add2702b62b67440c8c...

@bors

bors commented Jun 24, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@Mark-Simulacrum

Mark-Simulacrum commented Jun 24, 2017

Copy link
Copy Markdown
Member

@bors retry

os x timed out

@Mark-SimulacrumMark-Simulacrum added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 24, 2017
@Mark-Simulacrum

Mark-Simulacrum commented Jun 26, 2017

Copy link
Copy Markdown
Member

@bors retry

Trying to get bors to recognize world state...

@bors

bors commented Jun 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 45af6ee with merge 0254fde8fcb438adf9ea40df42b25b7a17764e60...

@bors

bors commented Jun 26, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@kennytm

kennytm commented Jun 26, 2017

Copy link
Copy Markdown
Member

macOS (64-bit dist) stuck when compiling stage0-rustc, spurious.

[01:35:28] Compiling proc_macro v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libproc_macro)
[01:35:58] Compiling rustc_const_math v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_const_math)
[01:36:05] Compiling syntax_ext v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libsyntax_ext)
[01:36:39] Compiling rustc v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc)
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.

@alexcrichton

alexcrichton commented Jun 26, 2017

Copy link
Copy Markdown
Member

@bors: retry

@carols10cents

carols10cents commented Jun 26, 2017

Copy link
Copy Markdown
Member

@bors retry

umm 1 osx builder timed out (red) 4 were terminated (gray)?

@kennytm

kennytm commented Jun 26, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@carols10cents If any job in the build completed abnormally, all other running jobs will be canceled so another PR can start immediately.

@arielb1

arielb1 commented Jun 29, 2017

Copy link
Copy Markdown
Contributor

@bors rollup

arielb1 pushed a commit to arielb1/rust that referenced this pull request Jun 29, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#42884- stepancheg:set-env-run-pass, r=alex…
4bae0d8
…crichton
Move global vars changing tests into run-pass
Should fix race rust-lang#42795
@arielb1arielb1 mentioned this pull request Jun 29, 2017
Merged
bors added a commit that referenced this pull request Jun 29, 2017
@bors
Auto merge of#42964- arielb1:rollup, r=arielb1
7acce37
Rollup of 12 pull requests
- Successful merges: #42219, #42831, #42832, #42884, #42886, #42901, #42919, #42920, #42946, #42953, #42955, #42958
- Failed merges:
@bors
bors merged commit 45af6ee into rust-lang:masterJun 29, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@stepancheg@rust-highfive@alexcrichton@bors@Mark-Simulacrum@kennytm@carols10cents@arielb1@sfackler