Uh oh!
There was an error while loading. Please reload this page.
Updated docker images to share scripts - #43129
Conversation
Ophirr33
commented
Jul 9, 2017
Fixes #42201 |
TimNN
commented
Jul 9, 2017
Is it possible that you forgot to commit the actual scripts? At least I can't find them in the Github diff. |
Ophirr33
commented
Jul 9, 2017
I did forget to push them, whoops. I just pushed them and then tried to squash the commits, but I don't think I'm squashing them correctly since it shows 3 commits that's trying to merge. |
TimNN
commented
Jul 9, 2017
@Ophirr33: The easiest thing is probably to just do a |
Ophirr33
commented
Jul 9, 2017
Got it, thanks for the help @TimNN! |
arielb1
commented
Jul 11, 2017
What's the status of this? Are you waiting for @malbarbo to review this? |
arielb1
commented
Jul 12, 2017
He does not even have r? rights. |
There was a problem hiding this comment.
It's ok to remove these comments, I don't think they necessarily add much to what's already written down
There was a problem hiding this comment.
Mind renaming this to include the term "cross" in the script name? I think this list of packages is mostly suitable for building crosstool-ng and such and running that inside the container.
Ophirr33
commented
Jul 13, 2017
@alexcrichton Done! |
alexcrichton
commented
Jul 13, 2017
@bors: r+ |
bors
commented
Jul 13, 2017
📌 Commit 2503461 has been approved by |
bors
commented
Jul 13, 2017
bors
commented
Jul 13, 2017
☀️ Test successful - status-appveyor, status-travis |
Attempts to resolve#42201. I managed to pull out five scripts (android-base-apt-get, ubuntu16-apt-get, make3, rustbuild-setup, and crosstool-ng). Let me know if there's more I can do or if I should change some names.
r? @malbarbo