Skip to content

librustc: Encode language items into a special lookup table. 9% improvement in hello world compile time. - #4368

Merged
pcwalton merged 1 commit into
rust-lang:incomingfrom
pcwalton:lang-items
Jan 7, 2013
Merged

librustc: Encode language items into a special lookup table. 9% improvement in hello world compile time.#4368
pcwalton merged 1 commit into
rust-lang:incomingfrom
pcwalton:lang-items

Conversation

@pcwalton

Copy link
Copy Markdown
Contributor

No description provided.

@pcwalton

Copy link
Copy Markdown
ContributorAuthor

r? @nikomatsakis

@nikomatsakis

Copy link
Copy Markdown
Contributor

r+

If we refactored the AST decoding a bit---as I think should now be possible thanks to @erickt's work on the auto-serialization stuff---we could convert this hand-written EBML code into #[auto_encode]-generated code very easily.

@pcwalton
pcwalton merged commit d2d1d98 into rust-lang:incomingJan 7, 2013
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 1, 2025
…-a-lot-instead
Fix tokio/file-io.rs test relying on `read`/`write` not being short
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
4396: Improve panic message for ast_from_text r=jonas-schievink a=edwin0cheng
Related: rust-lang#4368
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
5004: Fix panic in split/merge import assists r=matklad a=lnicola
Fixesrust-lang#4368rust-lang#4905
Not sure if this is the best solution here. Maybe the `make` functions should be fallible? We generally seem to be playing whack-a-mole with panics in assists, although most of them are `unwrap`s in the assist code.
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pcwalton@nikomatsakis