Uh oh!
There was an error while loading. Please reload this page.
libsyntax: Update view_item_use/import to reflect actual usage - #5004
Closed
luqmana wants to merge 2 commits into
Closed
libsyntax: Update view_item_use/import to reflect actual usage#5004luqmana wants to merge 2 commits into
luqmana wants to merge 2 commits into
Conversation
catamorphism
commented
Feb 18, 2013
Contributor
Great! This should cut down on confusion. |
bors added a commit
that referenced
this pull request
Feb 19, 2013
Seems like my previous pull request got lost along the way somehow. So here it is updated.
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
May 9, 2026
…-wsa-error-fix Remove `WSAESHUTDOWN` workaround for network socket writes
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
5004: Fix panic in split/merge import assists r=matklad a=lnicola Fixesrust-lang#4368rust-lang#4905 Not sure if this is the best solution here. Maybe the `make` functions should be fallible? We generally seem to be playing whack-a-mole with panics in assists, although most of them are `unwrap`s in the assist code. Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like my previous pull request got lost along the way somehow. So here it is updated.