Uh oh!
There was an error while loading. Please reload this page.
Expand docs of multi-address behavior of some UDP/TCP APIs. - #44209
Merged
Conversation
rust-highfive
commented
Aug 31, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
frewsxcvforce-pushed
the
frewsxcv-addr-other-scenarios
branch
2 times, most recently
from
August 31, 2017 04:24
042f26d to
3e96fd9Comparefrewsxcvforce-pushed
the
frewsxcv-addr-other-scenarios
branch
from
August 31, 2017 04:27
3e96fd9 to
8a09fd2Comparekennytm
reviewed
Aug 31, 2017
Member
There was a problem hiding this comment.
The doc tests failed, SocketAddr needs to be imported first.
Details
[00:57:39] failures:
[00:57:39] [00:57:39] ---- net/tcp.rs - net::tcp::TcpListener::bind (line 602) stdout ----
[00:57:39] error[E0433]: failed to resolve. Use of undeclared type or module `SocketAddr`
[00:57:39] --> net/tcp.rs:7:5
[00:57:39] |
[00:57:39] 7 | SocketAddr::from(([127, 0, 0, 1], 80)),
[00:57:39] | ^^^^^^^^^^ Use of undeclared type or module `SocketAddr`
[00:57:39] [00:57:39] error[E0433]: failed to resolve. Use of undeclared type or module `SocketAddr`
[00:57:39] --> net/tcp.rs:8:5
[00:57:39] |
[00:57:39] 8 | SocketAddr::from(([127, 0, 0, 1], 443)),
[00:57:39] | ^^^^^^^^^^ Use of undeclared type or module `SocketAddr`
[00:57:39] [00:57:39] thread 'rustc' panicked at 'couldn't compile the test', /checkout/src/librustdoc/test.rs:280:12
[00:57:39] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:57:39] [00:57:39] ---- net/tcp.rs - net::tcp::TcpStream::connect (line 140) stdout ----
[00:57:39] error[E0433]: failed to resolve. Use of undeclared type or module `SocketAddr`
[00:57:39] --> net/tcp.rs:7:5
[00:57:39] |
[00:57:39] 7 | SocketAddr::from(([127, 0, 0, 1], 8080)),
[00:57:39] | ^^^^^^^^^^ Use of undeclared type or module `SocketAddr`
[00:57:39] [00:57:39] error[E0433]: failed to resolve. Use of undeclared type or module `SocketAddr`
[00:57:39] --> net/tcp.rs:8:5
[00:57:39] |
[00:57:39] 8 | SocketAddr::from(([127, 0, 0, 1], 8081)),
[00:57:39] | ^^^^^^^^^^ Use of undeclared type or module `SocketAddr`
[00:57:39] [00:57:39] thread 'rustc' panicked at 'couldn't compile the test', /checkout/src/librustdoc/test.rs:280:12
[00:57:39] [00:57:39] [00:57:39] failures:
[00:57:39] net/tcp.rs - net::tcp::TcpListener::bind (line 602)
[00:57:39] net/tcp.rs - net::tcp::TcpStream::connect (line 140)
frewsxcvforce-pushed
the
frewsxcv-addr-other-scenarios
branch
from
August 31, 2017 13:20
8a09fd2 to
c548e51Comparefrewsxcv
commented
Aug 31, 2017
ContributorAuthor
Imports fixed in the latest force push. |
alexcrichton
commented
Aug 31, 2017
Member
@bors: r+ |
bors
commented
Aug 31, 2017
Collaborator
📌 Commit c548e51 has been approved by |
frewsxcv
commented
Aug 31, 2017
ContributorAuthor
@bors rollup |
frewsxcvforce-pushed
the
frewsxcv-addr-other-scenarios
branch
from
August 31, 2017 15:24
c548e51 to
0a716fdComparefrewsxcv
commented
Aug 31, 2017
ContributorAuthor
fixed another import issue @bors r=alexcrichton diff --git a/src/libstd/net/tcp.rs b/src/libstd/net/tcp.rs
index 2fb5d2b0ac..5467eff202 100644
--- a/src/libstd/net/tcp.rs+++ b/src/libstd/net/tcp.rs@@ -599,7 +599,7 @@ impl TcpListener {
/// TCP listener bound to `127.0.0.1:443`:
///
/// ```no_run
- /// use std::net::{SocketAddr, TcpStream};+ /// use std::net::{SocketAddr, TcpListener};
///
/// let addrs = [
/// SocketAddr::from(([127, 0, 0, 1], 80)), |
bors
commented
Aug 31, 2017
Collaborator
📌 Commit 0a716fd has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 31, 2017
…ios, r=alexcrichton Expand docs of multi-address behavior of some UDP/TCP APIs. Fixesrust-lang#22569.
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Sep 1, 2017
…ios, r=alexcrichton Expand docs of multi-address behavior of some UDP/TCP APIs. Fixesrust-lang#22569.
bors
commented
Sep 1, 2017
Collaborator
☔ The latest upstream changes (presumably #44233) made this pull request unmergeable. Please resolve the merge conflicts. |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 11, 2017
…=frewsxcv Clarify the behavior of UDP sockets wrt. multiple addresses in `connect` CC @frewsxcvrust-lang#22569rust-lang#44209
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 11, 2017
…=frewsxcv Clarify the behavior of UDP sockets wrt. multiple addresses in `connect` CC @frewsxcvrust-lang#22569rust-lang#44209
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 13, 2017
…=frewsxcv Clarify the behavior of UDP sockets wrt. multiple addresses in `connect` CC @frewsxcvrust-lang#22569rust-lang#44209
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 14, 2017
…=frewsxcv Clarify the behavior of UDP sockets wrt. multiple addresses in `connect` CC @frewsxcvrust-lang#22569rust-lang#44209
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 15, 2017
…=frewsxcv Clarify the behavior of UDP sockets wrt. multiple addresses in `connect` CC @frewsxcvrust-lang#22569rust-lang#44209
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#22569.