Skip to content

stabilize mem::discriminant (closes #24263) - #44263

Merged
bors merged 1 commit into
rust-lang:masterfrom
durka:stabilize-discriminant
Sep 4, 2017
Merged

stabilize mem::discriminant (closes #24263)#44263
bors merged 1 commit into
rust-lang:masterfrom
durka:stabilize-discriminant

Conversation

@durka

@durkadurka commented Sep 2, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Sep 2, 2017

Copy link
Copy Markdown
Contributor

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@dtolnaydtolnay added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api [DEPRECATED; DO NOT USE] labels Sep 2, 2017
@dtolnay

dtolnay commented Sep 2, 2017

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 2, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit d516434 has been approved by dtolnay

@est31

est31 commented Sep 2, 2017

Copy link
Copy Markdown
Member

@dtolnay if this is to be merged on beta, #44262 has to be as well.

@durka

durka commented Sep 2, 2017

Copy link
Copy Markdown
ContributorAuthor

If it's going to beta, the "since" field should be changed as well.

@durka

durka commented Sep 2, 2017

Copy link
Copy Markdown
ContributorAuthor

I don't think this depends on #44262. That splits out #[repr(i128)] from the i128_type feature gate but doesn't stabilize either one.

@est31

est31 commented Sep 2, 2017

Copy link
Copy Markdown
Member

ahh right its still unstable.

@bors

bors commented Sep 3, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d516434 with merge 0006d3e...

bors added a commit that referenced this pull request Sep 3, 2017
@bors
Auto merge of#44263- durka:stabilize-discriminant, r=dtolnay
0006d3e
stabilize mem::discriminant (closes#24263)
@bors

bors commented Sep 4, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: dtolnay
Pushing 0006d3e to master...

@bors
bors merged commit d516434 into rust-lang:masterSep 4, 2017
@alexcrichtonalexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 13, 2017
@alexcrichton

alexcrichton commented Sep 13, 2017

Copy link
Copy Markdown
Member

Accepting for backport according to the last libs triage

@durka

durka commented Sep 13, 2017

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton should I do that, or will you? including fixing up the since fields?

@alexcrichton

alexcrichton commented Sep 13, 2017

Copy link
Copy Markdown
Member

Ah it's ok, I'll do it at some point with other backports. Want to send a PR to master to update the fields?

@durkadurka mentioned this pull request Sep 13, 2017
Merged
@durka

durka commented Sep 13, 2017

Copy link
Copy Markdown
ContributorAuthor

#44552

@alexcrichton

alexcrichton commented Sep 13, 2017

Copy link
Copy Markdown
Member

Thanks!

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 14, 2017
@frewsxcv
Rollup merge ofrust-lang#44552- durka:patch-42, r=alexcrichton
24c4e26
update "since" for discriminant_value
It's [going](rust-lang#44263 (comment)) to be backported to beta.
r? @alexcrichton
@alexcrichtonalexcrichton mentioned this pull request Sep 14, 2017
Merged
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 14, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 15, 2017
@frewsxcv
Rollup merge ofrust-lang#44552- durka:patch-42, r=alexcrichton
ffd286b
update "since" for discriminant_value
It's [going](rust-lang#44263 (comment)) to be backported to beta.
r? @alexcrichton
@dtolnaydtolnay added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 21, 2017
@dtolnaydtolnay mentioned this pull request Sep 21, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dtolnaydtolnay

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.relnotesMarks issues that should be documented in the release notes of the next release.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@durka@rust-highfive@dtolnay@bors@est31@alexcrichton