[beta] Attempt to fix the component manifest problem for rls-preview by nrc · Pull Request #44357 · rust-lang/rust

nrc · 2017-09-05T22:19:56Z

cc #44270

see #44352

rust-highfive · 2017-09-05T22:20:06Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2017-09-05T22:20:06Z

Warning

Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

nrc · 2017-09-05T22:20:37Z

@bors r=@alexcrichton p=10 (from #44352)

bors · 2017-09-05T22:20:38Z

📌 Commit 76115f3 has been approved by @alexcrichton

alexcrichton · 2017-09-05T22:25:19Z

@nrc want to include the beta bump as well by changing this line?

(that way a new beta will be released when this is merged)

bors · 2017-09-05T22:32:56Z

⌛ Testing commit 76115f3ce9a83131eb7951649ed2f38ac6673a94 with merge 15c1035eb95cdfea4ec50afcb0104c8c94060234...

bors · 2017-09-05T23:33:44Z

💔 Test failed - status-appveyor

alexcrichton · 2017-09-06T02:54:32Z

I wonder if --component-name is changing the name of the tarball?

nrc · 2017-09-07T04:33:07Z

The problem seems to be that the save-analysis data for std is missing. I thought we only produced that on nightly, which would explain things, but I couldn't find such a condition in the code.

nrc · 2017-09-07T04:36:45Z

I realise this doesn't explain why we only hit this bug with this patch though

alexcrichton · 2017-09-07T14:15:24Z

@nrc you noted on IRC that you weren't able to reproduce locally, but I wonder if this is related to these lines?

rust/src/bootstrap/dist.rs

Lines 1282 to 1284 in 133aefc

cp_r(&work.join(&format!("{}-{}", pkgname(build,"rls"), target))
.join("rls"),
&exe.join("rls"));

That may explain the windows-specific-ness?

bors · 2017-09-11T01:17:46Z

⌛ Testing commit 76115f3ce9a83131eb7951649ed2f38ac6673a94 with merge 6adfa7085021a556081fafb5b272ff9c6086c445...

frewsxcv · 2017-09-11T01:20:02Z

why is bors testing this again? @bors retry r-

nrc · 2017-09-14T04:28:42Z

@bors r=alexcrichton

bors · 2017-09-14T04:28:43Z

📌 Commit e25513c has been approved by alexcrichton

bors · 2017-09-14T06:08:57Z

⌛ Testing commit e25513c with merge 9637179...

[beta] Attempt to fix the component manifest problem for rls-preview cc #44270 see #44352

bors · 2017-09-14T07:02:13Z

💔 Test failed - status-travis

kennytm · 2017-09-14T07:34:56Z

dist-fuchsia errored, failed to deploy.

uploading "9637179c7c345460504fb7bf36636d7fb43d1d1f/rust-analysis-beta-aarch64-unknown-fuchsia.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
Invalid S3 Access Key Id, Stopping Deploy
failed to deploy

@alexcrichton is #44385 (Rotate Travis/AppVeyor S3 keys) needed?

The default install used to include rustc, rust-std, and rust-docs, but the refactoring in commit 6b3413d make rustc only default in extended builds. This commit makes rustc installed by default again.

Haven't done this in awhile so seems like a good idea!

Travis is in the process of [rolling out an update][update] but looks like our tests are breaking, let's temporarily roll back to get the queue moving again. [update]: https://blog.travis-ci.com/2017-08-29-trusty-image-updates

In rust-lang#42436 the behavior for spawning processes on Windows was tweaked slightly to fix various bugs, but this caused rust-lang#42791 as a regression, namely that to spawn batch scripts they need to be manually spawned with `cmd /c` instead now. This updates the compiler to handle this case explicitly for Emscripten. Closesrust-lang#42791

It's going to be backported to beta.

cc rust-lang#44270

alexcrichton · 2017-09-14T17:39:03Z

Yeah, I've now also hijacked this PR to bump the beta to .3 and backport these PRs:

@bors: r+

bors · 2017-09-14T17:39:04Z

📌 Commit 25676e0 has been approved by alexcrichton

bors · 2017-09-14T19:36:16Z

⌛ Testing commit 25676e0 with merge e41812774ba102ef66137375008b6002527ce686...

bors · 2017-09-14T19:37:07Z

💔 Test failed - status-appveyor

alexcrichton · 2017-09-14T19:39:28Z

@bors: retry

s3 is down

bors · 2017-09-15T00:29:11Z

⌛ Testing commit 25676e0 with merge ea1fd7d...

[beta] Attempt to fix the component manifest problem for rls-preview cc #44270 see #44352

bors · 2017-09-15T04:22:40Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ea1fd7d to beta...

alexcrichton · 2017-09-15T13:58:53Z

$ rls +beta
<never exits>

It works!

rust-highfive assigned nikomatsakis Sep 5, 2017

nrc mentioned this pull request Sep 5, 2017
[beta] Attempt to fix the component manifest problem for rls-preview #44352
Closed

nrc assigned alexcrichton and unassigned nikomatsakis Sep 5, 2017

aidanhs added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 7, 2017

nrc force-pushed the rls-manifest-beta-2 branch from 76115f3 to e25513cCompare September 14, 2017 04:27

bors added a commit that referenced this pull request Sep 14, 2017
Auto merge of#44357- nrc:rls-manifest-beta-2, r=alexcrichton
9637179
[beta] Attempt to fix the component manifest problem for rls-preview cc #44270 see #44352

durkaand others added 3 commits September 14, 2017 10:37

stabilize mem::discriminant (closesrust-lang#24263)
c4474ab

Include rustc in the default ./x.py install
0df9c54
The default install used to include rustc, rust-std, and rust-docs, but the refactoring in commit 6b3413d make rustc only default in extended builds. This commit makes rustc installed by default again.

Rotate Travis/AppVeyor S3 keys
27e18d3
Haven't done this in awhile so seems like a good idea!

alexcrichtonand others added 5 commits September 14, 2017 10:37

travis: Downgrade to previous images temporarily
65bf0e2
Travis is in the process of [rolling out an update][update] but looks like our tests are breaking, let's temporarily roll back to get the queue moving again. [update]: https://blog.travis-ci.com/2017-08-29-trusty-image-updates

update "since" for discriminant_value
6c6a2c1
It's going to be backported to beta.

Attempt to fix the component manifest problem for rls-preview
45b426c
cc rust-lang#44270

Bump beta to .3
25676e0

alexcrichton force-pushed the rls-manifest-beta-2 branch from e25513c to 25676e0Compare September 14, 2017 17:38

bors added a commit that referenced this pull request Sep 15, 2017
Auto merge of#44357- nrc:rls-manifest-beta-2, r=alexcrichton
ea1fd7d
[beta] Attempt to fix the component manifest problem for rls-preview cc #44270 see #44352

bors merged commit 25676e0 into rust-lang:betaSep 15, 2017

This was referenced Sep 15, 2017
The rls-preview component on beta is "corrupted" #44270
Closed
Emscripten target broken on win32 with 1.20.0 release #44443
Closed

Uh oh!

Uh oh!

Conversation

nrc commented Sep 5, 2017

Uh oh!

rust-highfive commented Sep 5, 2017

Uh oh!

rust-highfive commented Sep 5, 2017

Uh oh!

nrc commented Sep 5, 2017

Uh oh!

bors commented Sep 5, 2017

Uh oh!

alexcrichton commented Sep 5, 2017

Uh oh!

bors commented Sep 5, 2017

Uh oh!

bors commented Sep 5, 2017

Uh oh!

alexcrichton commented Sep 6, 2017

Uh oh!

nrc commented Sep 7, 2017

Uh oh!

nrc commented Sep 7, 2017

Uh oh!

alexcrichton commented Sep 7, 2017

Uh oh!

bors commented Sep 11, 2017

Uh oh!

frewsxcv commented Sep 11, 2017

Uh oh!

nrc commented Sep 14, 2017

Uh oh!

bors commented Sep 14, 2017

Uh oh!

bors commented Sep 14, 2017

Uh oh!

bors commented Sep 14, 2017

Uh oh!

kennytm commented Sep 14, 2017

Uh oh!

alexcrichton commented Sep 14, 2017

Uh oh!

bors commented Sep 14, 2017

Uh oh!

bors commented Sep 14, 2017

Uh oh!

bors commented Sep 14, 2017

Uh oh!

alexcrichton commented Sep 14, 2017

Uh oh!

bors commented Sep 15, 2017

Uh oh!

bors commented Sep 15, 2017

Uh oh!

alexcrichton commented Sep 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants