Uh oh!
There was an error while loading. Please reload this page.
rustbook: remove dead test functions - #44313
Merged
Merged
Conversation
rust-highfive
commented
Sep 4, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
nikomatsakis
commented
Sep 5, 2017
Contributor
@bors r+ |
bors
commented
Sep 5, 2017
Collaborator
📌 Commit adbb820 has been approved by |
nikomatsakis
commented
Sep 5, 2017
Contributor
@steveklabnik feel free to tell stop bors if you disagree; deleting dead code almost always seems good to me, though, since it's "still around" in git... |
steveklabnik
commented
Sep 5, 2017
Contributor
I originally added it because I figured we'd need to test the book; if it's being tested some other way, then yeah, seems fine! |
RalfJung
commented
Sep 5, 2017
MemberAuthor
if it is tested at all (which I do not know), then it is tested another way. |
frewsxcv
commented
Sep 6, 2017
Contributor
@bors rollup |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Sep 7, 2017
rustbook: remove dead test functions There is no "test" subcommand added to the `clap::App`, so this is all dead code. Cc @steveklabnik -- your [commit](RalfJung@a076961) introducing this stated the intention of having both commands, but it seems nobody has missed the `test` command since February.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no "test" subcommand added to the
clap::App, so this is all dead code.Cc @steveklabnik -- your commit introducing this stated the intention of having both commands, but it seems nobody has missed the
testcommand since February.