Skip to content

Include rustc in the default ./x.py install - #44353

Merged
bors merged 1 commit into
rust-lang:masterfrom
cuviper:install-rustc
Sep 7, 2017
Merged

Include rustc in the default ./x.py install#44353
bors merged 1 commit into
rust-lang:masterfrom
cuviper:install-rustc

Conversation

@cuviper

Copy link
Copy Markdown
Member

The default install used to include rustc, rust-std, and rust-docs, but
the refactoring in commit 6b3413d make rustc only default in
extended builds. This commit makes rustc installed by default again.

The default install used to include rustc, rust-std, and rust-docs, but
the refactoring in commit 6b3413d make rustc only default in
extended builds. This commit makes rustc installed by default again.
@cuviper

Copy link
Copy Markdown
MemberAuthor

In particular, the change was here, formerly using default(true) and then using builder.build.config.extended. I suspect that was just an accident, cut-and-paste from other install clauses.

This needs to be fixed in beta too.

@Mark-SimulacrumMark-Simulacrum self-assigned this Sep 5, 2017
@Mark-SimulacrumMark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 5, 2017
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Sep 5, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 110efe2 has been approved by Mark-Simulacrum

@Mark-SimulacrumMark-Simulacrum added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Sep 5, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 6, 2017
…acrum
Include rustc in the default `./x.py install`
The default install used to include rustc, rust-std, and rust-docs, but
the refactoring in commit 6b3413d make rustc only default in
extended builds. This commit makes rustc installed by default again.
@alexcrichtonalexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 6, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 7, 2017
…acrum
Include rustc in the default `./x.py install`
The default install used to include rustc, rust-std, and rust-docs, but
the refactoring in commit 6b3413d make rustc only default in
extended builds. This commit makes rustc installed by default again.
bors added a commit that referenced this pull request Sep 7, 2017
@bors
bors merged commit 110efe2 into rust-lang:masterSep 7, 2017
@alexcrichtonalexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 12, 2017
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 14, 2017
@cuviper
cuviper deleted the install-rustc branch September 26, 2017 06:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cuviper@Mark-Simulacrum@bors@alexcrichton