Skip to content

Add proper help line for -C inline threshold - #44548

Merged
bors merged 2 commits into
rust-lang:masterfrom
oyvindln:rustc_help_fix
Sep 18, 2017
Merged

Add proper help line for -C inline threshold#44548
bors merged 2 commits into
rust-lang:masterfrom
oyvindln:rustc_help_fix

Conversation

@oyvindln

@oyvindlnoyvindln commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

Looks like someone accidentally some words when adding this.

This also remove a period on a different help line for consistency, as no options have a period.

@oyvindln
Add proper help line for inline threshold
edf1622
Also remove a period on a different help line for consistency
@rust-highfive

rust-highfive commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

retep998
retep998 reviewed Sep 13, 2017
View reviewed changes
Comment threadsrc/librustc/session/config.rs Outdated
"Set the optimization fuel quota for a crate."),
"Set the optimization fuel quota for a crate"),
print_fuel: Option<String> = (None, parse_opt_string, [TRACKED],
"Make Rustc print the total optimization fuel used by a crate."),

@retep998retep998Sep 13, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this period?

@oyvindlnoyvindlnSep 13, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice this one. Should I remove and make them start with lowercase so that everything is the same then?

retep998
retep998 reviewed Sep 13, 2017
View reviewed changes
Comment threadsrc/librustc/session/config.rs
linker_flavor: Option<LinkerFlavor> = (None, parse_linker_flavor, [UNTRACKED],
"Linker flavor"),
fuel: Option<(String, u64)> = (None, parse_optimization_fuel, [TRACKED],
"Set the optimization fuel quota for a crate."),

@retep998retep998Sep 13, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of two options that is capitalized. All the others start with lowercase letters.

@oyvindln

oyvindln commented Sep 13, 2017

Copy link
Copy Markdown
ContributorAuthor

The options under rustc --help actually start with an uppercase letter, unlike the ones under -C/Z/W help. Maybe the help lines should start with an uppercase letter everywhere?

@aidanhsaidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2017
@carols10cents

carols10cents commented Sep 18, 2017

Copy link
Copy Markdown
Member

review ping @arielb1! pinging you on irc too!

@arielb1

arielb1 commented Sep 18, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 18, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit e89748e has been approved by arielb1

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 18, 2017
@alexcrichton
Rollup merge ofrust-lang#44548- oyvindln:rustc_help_fix, r=arielb1
156698e
Add proper help line for `-C inline threshold`
Looks like someone accidentally some words when adding this.
This also remove a period on a different help line for consistency, as no options have a period.
@alexcrichtonalexcrichton mentioned this pull request Sep 18, 2017
Merged
bors added a commit that referenced this pull request Sep 18, 2017
@bors
Auto merge of#44678- alexcrichton:rollup, r=alexcrichton
0701b37
Rollup of 11 pull requests
- Successful merges: #44364, #44466, #44537, #44548, #44640, #44651, #44657, #44661, #44668, #44671, #44675
- Failed merges:
@bors
bors merged commit e89748e into rust-lang:masterSep 18, 2017
@ManishearthManishearth mentioned this pull request Sep 21, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@retep998retep998retep998 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@arielb1arielb1

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@oyvindln@rust-highfive@carols10cents@arielb1@bors@retep998@aidanhs