Skip to content

Add Example of IntoIterator as Trait Bound to Docs - #44668

Merged
bors merged 1 commit into
rust-lang:masterfrom
iwillspeak:into-iterator-docs
Sep 18, 2017
Merged

Add Example of IntoIterator as Trait Bound to Docs#44668
bors merged 1 commit into
rust-lang:masterfrom
iwillspeak:into-iterator-docs

Conversation

@iwillspeak

@iwillspeakiwillspeak commented Sep 18, 2017

Copy link
Copy Markdown
Contributor

Part of #44600.

@rust-highfive

rust-highfive commented Sep 18, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik

steveklabnik commented Sep 18, 2017

Copy link
Copy Markdown
Contributor

Thanks so much! This looks great.

@bors: r+ rollup

@bors

bors commented Sep 18, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit ebd0e4f has been approved by steveklabnik

@carols10centscarols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 18, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 18, 2017
@alexcrichton
Rollup merge ofrust-lang#44668- iwillspeak:into-iterator-docs, r=st…
196e8ae
…eveklabnik
Add Example of `IntoIterator` as Trait Bound to Docs
Part of rust-lang#44600.
@alexcrichtonalexcrichton mentioned this pull request Sep 18, 2017
Closed
bors added a commit that referenced this pull request Sep 18, 2017
@bors
Auto merge of#44676- alexcrichton:rollup, r=alexcrichton
4a8bc8a
Rollup of 10 pull requests
- Successful merges: #44364, #44466, #44537, #44640, #44651, #44657, #44661, #44668, #44671, #44675
- Failed merges:
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 18, 2017
@alexcrichton
Rollup merge ofrust-lang#44668- iwillspeak:into-iterator-docs, r=st…
4af3073
…eveklabnik
Add Example of `IntoIterator` as Trait Bound to Docs
Part of rust-lang#44600.
@alexcrichtonalexcrichton mentioned this pull request Sep 18, 2017
Merged
bors added a commit that referenced this pull request Sep 18, 2017
@bors
Auto merge of#44678- alexcrichton:rollup, r=alexcrichton
0701b37
Rollup of 11 pull requests
- Successful merges: #44364, #44466, #44537, #44548, #44640, #44651, #44657, #44661, #44668, #44671, #44675
- Failed merges:
@bors
bors merged commit ebd0e4f into rust-lang:masterSep 18, 2017
@iwillspeak
iwillspeak deleted the into-iterator-docs branch September 19, 2017 06:49
@ManishearthManishearth mentioned this pull request Sep 21, 2017
Closed
@peter-bpeter-b mentioned this pull request Sep 23, 2017
Closed
@bluss

bluss commented Sep 23, 2017

Copy link
Copy Markdown
Contributor

Small typo, should probably say "can be converted to an iterator" instead of "is still an iterator".

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@iwillspeak@rust-highfive@steveklabnik@bors@bluss@alexcrichton@carols10cents