Skip to content

Remove new and index methods already implement for Idx - #44893

Closed
spastorino wants to merge 2 commits into
rust-lang:masterfrom
spastorino:remove_new_and_index
Closed

Remove new and index methods already implement for Idx#44893
spastorino wants to merge 2 commits into
rust-lang:masterfrom
spastorino:remove_new_and_index

Conversation

@spastorino

@spastorinospastorino commented Sep 27, 2017

Copy link
Copy Markdown
Member

These are the rest of the repeated implementations for new and index methods. Follow up of #44889

@rust-highfive

rust-highfive commented Sep 27, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nikomatsakis

nikomatsakis commented Sep 27, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 27, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit e0e14c9 has been approved by nikomatsakis

@aidanhsaidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 28, 2017
@bors

bors commented Sep 30, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e0e14c9 with merge 4491ea5...

bors added a commit that referenced this pull request Sep 30, 2017
@bors
Auto merge of#44893- spastorino:remove_new_and_index, r=nikomatsakis
4491ea5
Remove new and index methods already implement for Idx
These are the rest of the repeated implementations for new and index methods. Follow up of #44889
@bors

bors commented Sep 30, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 4491ea5 to master...

@borsbors mentioned this pull request Sep 30, 2017
Merged
@spastorino

spastorino commented Sep 30, 2017

Copy link
Copy Markdown
MemberAuthor

This is already merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spastorino@rust-highfive@nikomatsakis@bors@aidanhs