Skip to content

Remove DepNodeIndex::new is already impl for Idx - #44889

Closed
spastorino wants to merge 1 commit into
rust-lang:masterfrom
spastorino:remove_new
Closed

Remove DepNodeIndex::new is already impl for Idx#44889
spastorino wants to merge 1 commit into
rust-lang:masterfrom
spastorino:remove_new

Conversation

@spastorino

@spastorinospastorino commented Sep 27, 2017

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

rust-highfive commented Sep 27, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@arielb1

arielb1 commented Sep 27, 2017

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 27, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit cde47ce has been approved by arielb1

@spastorinospastorino mentioned this pull request Sep 27, 2017
Closed
@aidanhsaidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 28, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#44889- spastorino:remove_new, r=arielb1
37c74e1
Remove DepNodeIndex::new is already impl for Idx
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Sep 29, 2017
Closed
bors added a commit that referenced this pull request Sep 30, 2017
@bors
Auto merge of#44893- spastorino:remove_new_and_index, r=nikomatsakis
4491ea5
Remove new and index methods already implement for Idx
These are the rest of the repeated implementations for new and index methods. Follow up of #44889
bors added a commit that referenced this pull request Sep 30, 2017
@bors
Auto merge of#44936- Mark-Simulacrum:rollup, r=Mark-Simulacrum
c4cca3a
Rollup of 15 pull requests
- Successful merges: #44124, #44287, #44320, #44694, #44708, #44794, #44797, #44824, #44836, #44840, #44845, #44854, #44889, #44900, #44903
- Failed merges:
@bors

bors commented Sep 30, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #44936) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum

Mark-Simulacrum commented Sep 30, 2017

Copy link
Copy Markdown
Member

Merged in #44936.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arielb1arielb1

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@spastorino@rust-highfive@arielb1@bors@Mark-Simulacrum@aidanhs