Remove support for the PNaCl target (le32-unknown-nacl) by est31 · Pull Request #45041 · rust-lang/rust

est31 · 2017-10-05T03:43:58Z

This removes support for the le32-unknown-nacl target which is currently supported by rustc on tier 3. Despite the "nacl" in the name, the target doesn't output native code (x86, ARM, MIPS), instead it outputs binaries in the PNaCl format.

There are two reasons for the removal:

Google has announced deprecation of the PNaCl format. The suggestion is to migrate to wasm. Happens we already have a wasm backend!
Our PNaCl LLVM backend is provided by the fastcomp patch set that the LLVM fork used by rustc contains in addition to vanilla LLVM (src/llvm/lib/Target/JSBackend/NaCl). Upstream LLVM doesn't have PNaCl support. Removing PNaCl support will enable us to move away from fastcomp (Tracking issue for supporting asm.js and WebAssembly without Fastcomp #44006) and have a lighter set of patches on top of upstream LLVM inside our LLVM fork. This will help distribution packagers of Rust.

Fixes#42420

rust-highfive · 2017-10-05T03:44:10Z

r? @BurntSushi

(rust_highfive has picked a reviewer for you, use r? to override)

est31 · 2017-10-05T03:45:13Z

r? @eddyb

est31 · 2017-10-05T03:47:15Z

cc @tlively @eholk

eddyb · 2017-10-05T08:38:06Z

r? @alexcrichton

alexcrichton · 2017-10-05T14:46:43Z

@bors: r+

bors · 2017-10-05T14:46:44Z

📌 Commit 327116a has been approved by alexcrichton

bors · 2017-10-09T04:59:08Z

⌛ Testing commit 327116a with merge b2f67c8...

Remove support for the PNaCl target (le32-unknown-nacl) This removes support for the `le32-unknown-nacl` target which is currently supported by rustc on tier 3. Despite the "nacl" in the name, the target doesn't output native code (x86, ARM, MIPS), instead it outputs binaries in the PNaCl format. There are two reasons for the removal: * Google [has announced](https://blog.chromium.org/2017/05/goodbye-pnacl-hello-webassembly.html) deprecation of the PNaCl format. The suggestion is to migrate to wasm. Happens we already have a wasm backend! * Our PNaCl LLVM backend is provided by the fastcomp patch set that the LLVM fork used by rustc contains in addition to vanilla LLVM (`src/llvm/lib/Target/JSBackend/NaCl`). Upstream LLVM doesn't have PNaCl support. Removing PNaCl support will enable us to move away from fastcomp (#44006) and have a lighter set of patches on top of upstream LLVM inside our LLVM fork. This will help distribution packagers of Rust. Fixes#42420

bors · 2017-10-09T07:22:26Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b2f67c8 to master...

Remove obsolete references to target_env = wasi, target_os = nacl, target_os = osx, and a typo'd target_os = fushsia that didn't compile when fixed. - target_env = wasi is dead: rust-lang/rust#60117 - target_os = nacl is dead: rust-lang/rust#45041 - target_os = osx is dead, but I can't find a link.

1735: Cleanup cfg blocks r=asomers a=rtzoeller Remove obsolete references to target_env = wasi, target_os = nacl, target_os = osx, and a typo'd target_os = fushsia that didn't compile when fixed. - target_env = wasi is dead: rust-lang/rust#60117 - target_os = nacl is dead: rust-lang/rust#45041 - target_os = osx is dead, but I can't find a link. Found while exploring `--check-cfg`, as mentioned in #1734. Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>

See rust-lang#45041 for the removal of the target (le32-unknown-nacl).

- `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: `nvptx64-nvidia-cuda` - `target_arch=le32`: target was removed (rust-lang#45041) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).

…k-cfgs, r=Mark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang#45041) - ~~`release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449 (despite the changes being done more than 6 months ago there hasn't been any rustfmt subtree sync) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).

See rust-lang#45041 for the removal of the target (le32-unknown-nacl).

- `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: `nvptx64-nvidia-cuda` - `target_arch=le32`: target was removed (rust-lang#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).

…k-cfgs, r=Mark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).

…cfgs, r=Mark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).

…ark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang/rust#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).

See rust-lang/rust#45041 for the removal of the target (le32-unknown-nacl).

…ark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang/rust#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).

est31 added 5 commits October 5, 2017 05:01

Remove nacl from librustc_llvm
6f7dd65

Remove nacl from librustc_back
b8fad2d

Remove nacl from libstd
aad1c99

Remove nacl from libtest
329b901

Remove nacl from librustdoc
327116a

rust-highfive assigned BurntSushi Oct 5, 2017

rust-highfive assigned eddyb and unassigned BurntSushi Oct 5, 2017

rust-highfive assigned alexcrichton and unassigned eddyb Oct 5, 2017

shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 6, 2017

bors merged commit 327116a into rust-lang:masterOct 9, 2017

bors mentioned this pull request Oct 9, 2017
cleanup: rustc doesn't use an external archiver #45102
Merged

pitdicker mentioned this pull request Oct 22, 2017
Drop support for PNaCL dhardy/rand#19
Merged

kornelski mentioned this pull request Nov 20, 2017
Rust has obsoleted this DiamondLovesYou/rust-webm#1
Closed

rtzoeller mentioned this pull request Jun 6, 2022
Cleanup cfg blocks nix-rust/nix#1735
Merged

Urgau added a commit to Urgau/rust that referenced this pull request Jan 19, 2023
Remove outdated cfg on le32
eb33d2c
See rust-lang#45041 for the removal of the target (le32-unknown-nacl).

Urgau mentioned this pull request Jan 19, 2023
bootstrap: cleanup the list of extra check cfgs #107080
Merged

Urgau added a commit to Urgau/rust that referenced this pull request Jan 25, 2023
Remove outdated cfg on le32
dde74fe
See rust-lang#45041 for the removal of the target (le32-unknown-nacl).

thomcc pushed a commit to pgcentralfoundation/postgrestd that referenced this pull request May 31, 2023
Remove outdated cfg on le32
ab56c60
See rust-lang/rust#45041 for the removal of the target (le32-unknown-nacl).

Navigation Menu

Uh oh!

Uh oh!

Remove support for the PNaCl target (le32-unknown-nacl) - #45041

Remove support for the PNaCl target (le32-unknown-nacl)#45041
bors merged 5 commits into
rust-lang:masterfrom
est31:master

est31 commented Oct 5, 2017

Uh oh!

rust-highfive commented Oct 5, 2017

Uh oh!

est31 commented Oct 5, 2017

Uh oh!

est31 commented Oct 5, 2017

Uh oh!

eddyb commented Oct 5, 2017

Uh oh!

alexcrichton commented Oct 5, 2017

Uh oh!

bors commented Oct 5, 2017

Uh oh!

bors commented Oct 9, 2017

Uh oh!

bors commented Oct 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

est31 commented Oct 5, 2017

Uh oh!

rust-highfive commented Oct 5, 2017

Uh oh!

est31 commented Oct 5, 2017

Uh oh!

est31 commented Oct 5, 2017

Uh oh!

eddyb commented Oct 5, 2017

Uh oh!

alexcrichton commented Oct 5, 2017

Uh oh!

bors commented Oct 5, 2017

Uh oh!

bors commented Oct 9, 2017

Uh oh!

bors commented Oct 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants