Uh oh!
There was an error while loading. Please reload this page.
Categorize WASI as an "OS" rather than as an "environment". - #60117
Conversation
rust-highfive
commented
Apr 19, 2019
(rust_highfive has picked a reviewer for you, use r? to override) |
sunfishcode
commented
Apr 19, 2019
alexcrichton
commented
Apr 19, 2019
@bors: r+ |
bors
commented
Apr 19, 2019
📌 Commit dcdcffc5d885bd285e7b0d28b82e0da44c9e75eb has been approved by |
bors
commented
Apr 19, 2019
⌛ Testing commit dcdcffc5d885bd285e7b0d28b82e0da44c9e75eb with merge 711ae553f8c04ebde38cca890e7bd43f684eab07... |
bors
commented
Apr 20, 2019
💔 Test failed - checks-travis |
rust-highfive
commented
Apr 20, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
alexcrichton
commented
Apr 22, 2019
@sunfishcode FWIW I think the change to |
sunfishcode
commented
Apr 23, 2019
@alexcrichton Ok, I now have an updated PR to libc which includes the target_os change: rust-lang/libc#1325 |
sunfishcode
commented
Apr 25, 2019
rust-lang/libc#1325 landed, and the CI is now green here. |
alexcrichton
commented
Apr 26, 2019
Oh I think |
This adds more WASI support, and in particular adds support for WASI being a target_os rather than a target_env, which relates to this PR: rust-lang/rust#60117
Bump to 0.2.53 This adds more WASI support, and in particular adds support for WASI being a target_os rather than a target_env, which relates to this PR: rust-lang/rust#60117
rust-highfive
commented
Apr 26, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
alexcrichton
commented
Apr 26, 2019
@bors: r+ |
bors
commented
Apr 26, 2019
📌 Commit aafd1268700e872fd1d3a3e1d0c622aaa9c40eef has been approved by |
bors
commented
May 4, 2019
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
This distinction is fairly abstract, but in practice, the main advantage here is that LLVM's triple code considers WASI to be an OS, so this makes rustc agree with that.
sunfishcode
commented
May 4, 2019
Resolved Cargo.lock conflicts. @bors: r+ |
bors
commented
May 4, 2019
📌 Commit c07b52e has been approved by |
bors
commented
May 4, 2019
Categorize WASI as an "OS" rather than as an "environment". This distinction is fairly abstract, but in practice, the main advantage here is that LLVM's triple code considers WASI to be an OS, so this makes rustc agree with that.
bors
commented
May 4, 2019
☀️ Test successful - checks-travis, status-appveyor |
- WASI is now categorized as an OS rather than an environment. (rust-lang/rust#60117) - The WASI triple is renamed from wasm32-unknown-wasi to wasm32-wasi. (rust-lang/rust#60585)
In addition to using the new triple, this arranges for users get the following fixes: - rust-lang/rust#60117 - rust-lang/rust#59727
Remove obsolete references to target_env = wasi, target_os = nacl, target_os = osx, and a typo'd target_os = fushsia that didn't compile when fixed. - target_env = wasi is dead: rust-lang/rust#60117 - target_os = nacl is dead: rust-lang/rust#45041 - target_os = osx is dead, but I can't find a link.
1735: Cleanup cfg blocks r=asomers a=rtzoeller Remove obsolete references to target_env = wasi, target_os = nacl, target_os = osx, and a typo'd target_os = fushsia that didn't compile when fixed. - target_env = wasi is dead: rust-lang/rust#60117 - target_os = nacl is dead: rust-lang/rust#45041 - target_os = osx is dead, but I can't find a link. Found while exploring `--check-cfg`, as mentioned in #1734. Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
- WASI is now categorized as an OS rather than an environment. (rust-lang/rust#60117) - The WASI triple is renamed from wasm32-unknown-wasi to wasm32-wasi. (rust-lang/rust#60585)
This distinction is fairly abstract, but in practice, the main advantage
here is that LLVM's triple code considers WASI to be an OS, so this
makes rustc agree with that.