Skip to content

Moved details of unstable non-ascii identifiers from the Reference - #45250

Merged
bors merged 2 commits into
rust-lang:masterfrom
brauliobz:non-ascii-idents-details
Oct 15, 2017
Merged

Moved details of unstable non-ascii identifiers from the Reference#45250
bors merged 2 commits into
rust-lang:masterfrom
brauliobz:non-ascii-idents-details

Conversation

@brauliobz

@brauliobzbrauliobz commented Oct 13, 2017

Copy link
Copy Markdown
Contributor

Moved details of unstable non-ascii identifiers from the Reference to the Unstable book

r? @steveklabnik

@rust-highfive

rust-highfive commented Oct 13, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brauliobzbrauliobz mentioned this pull request Oct 13, 2017
Merged
@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2017
steveklabnik
steveklabnik suggested changes Oct 13, 2017
View reviewed changes

@steveklabniksteveklabnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but

[01:27:20] unstable-book/print.html:1496: broken link - unstable-book/keywords.html
[01:27:20] unstable-book/language-features/non-ascii-idents.html:123: broken link - unstable-book/keywords.html

you'll need to change the link to something like ../../reference/keywords.html#strict-keywords

@kennytmkennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2017
@kennytm

kennytm commented Oct 14, 2017

Copy link
Copy Markdown
Member

CI passed, assuming good to go.

@bors r=steveklabnik rollup

@bors

bors commented Oct 14, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 8e6119f has been approved by steveklabnik

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Oct 14, 2017
@kennytm
Rollup merge ofrust-lang#45250- brauliobz:non-ascii-idents-details,…
0f806dd
… r=steveklabnik
Moved details of unstable non-ascii identifiers from the Reference
Moved details of unstable non-ascii identifiers from the Reference to the Unstable book
r? @steveklabnik
@kennytmkennytm mentioned this pull request Oct 14, 2017
Closed
bors added a commit that referenced this pull request Oct 14, 2017
@bors
Auto merge of#45291- kennytm:rollup, r=kennytm
24834ee
Rollup of 9 pull requests
- Successful merges: #45113, #45250, #45255, #45258, #45263, #45264, #45269, #45280, #45289
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Oct 15, 2017
@kennytm
Rollup merge ofrust-lang#45250- brauliobz:non-ascii-idents-details,…
b6f4cea
… r=steveklabnik
Moved details of unstable non-ascii identifiers from the Reference
Moved details of unstable non-ascii identifiers from the Reference to the Unstable book
r? @steveklabnik
@kennytmkennytm mentioned this pull request Oct 15, 2017
Merged
bors added a commit that referenced this pull request Oct 15, 2017
@bors
Auto merge of#45299- kennytm:rollup, r=kennytm
8382f39
Rollup of 9 pull requests
- Successful merges: #45113, #45250, #45255, #45258, #45263, #45264, #45269, #45280, #45289
- Failed merges:
@bors
bors merged commit 8e6119f into rust-lang:masterOct 15, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@steveklabniksteveklabniksteveklabnik requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@steveklabniksteveklabnik

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brauliobz@rust-highfive@kennytm@bors@steveklabnik