Uh oh!
There was an error while loading. Please reload this page.
Fix TcpStream::connect_timeout on linux - #45269
Merged
Merged
Conversation
sfacklerforce-pushed
the
connect-timeout-fix
branch
from
October 14, 2017 02:37
53fedf2 to
2bd5238Comparealexcrichton
commented
Oct 14, 2017
Member
@bors: r+ |
bors
commented
Oct 14, 2017
Collaborator
📌 Commit 2bd5238 has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Oct 14, 2017
…xcrichton Fix TcpStream::connect_timeout on linux Linux appears to set POLLOUT when a conection's refused, which is pretty weird. Invert the check to look for an error explicitly. Also add an explict test for this case. Closesrust-lang#45265. r? @alexcrichton
Linux appears to set POLLOUT when a conection's refused, which is pretty weird. Invert the check to look for an error explicitly. Also add an explict test for this case. Closesrust-lang#45265.
sfacklerforce-pushed
the
connect-timeout-fix
branch
from
October 14, 2017 20:56
2bd5238 to
cab99a3Comparesfackler
commented
Oct 14, 2017
MemberAuthor
@bors r=alexcrichton |
bors
commented
Oct 14, 2017
Collaborator
📌 Commit cab99a3 has been approved by |
bors added a commit
that referenced
this pull request
Oct 14, 2017
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Oct 15, 2017
…xcrichton Fix TcpStream::connect_timeout on linux Linux appears to set POLLOUT when a conection's refused, which is pretty weird. Invert the check to look for an error explicitly. Also add an explict test for this case. Closesrust-lang#45265. r? @alexcrichton
bors added a commit
that referenced
this pull request
Oct 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux appears to set POLLOUT when a conection's refused, which is pretty
weird. Invert the check to look for an error explicitly. Also add an
explict test for this case.
Closes#45265.
r? @alexcrichton