Skip to content

[beta] Make Solaris builder compatible with Solaris 10 retry - #45443

Merged
bors merged 2 commits into
rust-lang:betafrom
bgermann:beta
Oct 24, 2017
Merged

[beta] Make Solaris builder compatible with Solaris 10 retry#45443
bors merged 2 commits into
rust-lang:betafrom
bgermann:beta

Conversation

@bgermann

@bgermannbgermann commented Oct 22, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Backport of #45343.

@bgermann
Make Solaris builder compatible with Solaris 10 retry
1dfc8d2
Unfortunately, #45255 does not quite cut it,
so use a different approach to have Solaris 10 compatibility
by tricking libbacktrace's autoconf tests.
The sysroot download routine is slightly changed, too.
(cherry picked from commit b3ea6e5)
@bgermann
Remove tabs
4c928f9
(cherry picked from commit 0597bda)
@rust-highfive

rust-highfive commented Oct 22, 2017

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

rust-highfive commented Oct 22, 2017

Copy link
Copy Markdown
Contributor

warningWarningwarning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@kennytm

kennytm commented Oct 22, 2017

Copy link
Copy Markdown
Member

This is a backport of #45343, currently [beta-nominated].

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2017
@kennytm

kennytm commented Oct 23, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@bors r+

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2017
@bors

bors commented Oct 23, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 4c928f9 has been approved by kennytm

@kennytm

kennytm commented Oct 23, 2017

Copy link
Copy Markdown
Member

@bors r+ retry

@bors

bors commented Oct 23, 2017

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Oct 23, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 4c928f9 has been approved by kennytm

@bors

bors commented Oct 23, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4c928f9 with merge c4008d6...

bors added a commit that referenced this pull request Oct 23, 2017
@bors
Auto merge of#45443- bgermann:beta, r=kennytm
c4008d6
[beta] Make Solaris builder compatible with Solaris 10 retry
Backport of #45343.
@bors

bors commented Oct 23, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@bgermann

bgermann commented Oct 23, 2017

Copy link
Copy Markdown
ContributorAuthor

Looks like a network issue.

@kennytm

kennytm commented Oct 24, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@bors retry

  1. The macOS check x86_64-apple-darwin job started 3 times
  2. On its third try, it failed to download rustc-1.21.0-x86_64-apple-darwin.tar.gz (hitting a "504 Gateway Time-out")

@bors

bors commented Oct 24, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4c928f9 with merge f724781...

bors added a commit that referenced this pull request Oct 24, 2017
@bors
Auto merge of#45443- bgermann:beta, r=kennytm
f724781
[beta] Make Solaris builder compatible with Solaris 10 retry
Backport of #45343.
@bors

bors commented Oct 24, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing f724781 to beta...

@bors
bors merged commit 4c928f9 into rust-lang:betaOct 24, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturonaturon

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bgermann@rust-highfive@kennytm@bors@aturon