Skip to content

Update docs for Diagnostic::span_suggestion(s) - #45486

Merged
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:patch-9
Oct 25, 2017
Merged

Update docs for Diagnostic::span_suggestion(s)#45486
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:patch-9

Conversation

@oli-obk

@oli-obkoli-obk commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

oli-obk
oli-obk commented Oct 24, 2017
View reviewed changes
Comment threadsrc/librustc_errors/diagnostic.rs
/// "try adding parentheses: `(tup.0).1`"
///
/// The message
///

@oli-obkoli-obkOct 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdown doesn't render the bullet points correctly if there's no empty line

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2017
@kennytm

kennytm commented Oct 24, 2017

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Oct 24, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 1ce1d99 has been approved by kennytm

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 25, 2017
@GuillaumeGomez
Rollup merge ofrust-lang#45486- oli-obk:patch-9, r=kennytm
a95d97a
Update docs for Diagnostic::span_suggestion(s)
@GuillaumeGomezGuillaumeGomez mentioned this pull request Oct 25, 2017
Merged
bors added a commit that referenced this pull request Oct 25, 2017
@bors
Auto merge of#45513- GuillaumeGomez:rollup, r=GuillaumeGomez
2f5ae25
Rollup of 5 pull requests
- Successful merges: #45361, #45461, #45465, #45486, #45502
- Failed merges:
@bors
bors merged commit 1ce1d99 into rust-lang:masterOct 25, 2017
@bors

bors commented Oct 25, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #45513) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
oli-obk deleted the patch-9 branch October 25, 2017 19:12
@oli-obk

oli-obk commented Oct 25, 2017

Copy link
Copy Markdown
ContributorAuthor

Bors is drunk

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oli-obk@rust-highfive@kennytm@bors@nikomatsakis