Skip to content

bootstrap: Add openssl configuration for sparc64-unknown-linux-gnu - #45465

Merged
bors merged 1 commit into
rust-lang:masterfrom
glaubitz:sparc64
Oct 25, 2017
Merged

bootstrap: Add openssl configuration for sparc64-unknown-linux-gnu#45465
bors merged 1 commit into
rust-lang:masterfrom
glaubitz:sparc64

Conversation

@glaubitz

@glaubitzglaubitz commented Oct 23, 2017

Copy link
Copy Markdown
Contributor

Hi!

This adds the target missing mapping for sparc64-unknown-linux-gnu.

See: #45456

Thanks

@rust-highfive

rust-highfive commented Oct 23, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2017
@Mark-Simulacrum

Mark-Simulacrum commented Oct 23, 2017

Copy link
Copy Markdown
Member

r? @alexcrichton

jrtc27
jrtc27 suggested changes Oct 23, 2017
View reviewed changes
Comment threadsrc/bootstrap/native.rs Outdated

@jrtc27jrtc27Oct 23, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's actually linux64-sparcv9: https://github.com/libtor/openssl/blob/1ad38e5/Configure#L385

@glaubitzglaubitzOct 23, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch, thank you. I was actually unsure about this but my tests aren't finished yet.

Will get back in a few minutes.

@glaubitzglaubitzOct 23, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed that now. I'm now testing whether we need to pass "-m64" as well (see the case for BSD-sparc64 further below).

@jrtc27jrtc27Oct 23, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, OpenSSL puts -m64 in there already for linux64-sparcv9.

@alexcrichton

alexcrichton commented Oct 23, 2017

Copy link
Copy Markdown
Member

@bors: r+ rollup

Thanks!

@alexcrichton

alexcrichton commented Oct 23, 2017

Copy link
Copy Markdown
Member

@bors: r+ rollup

@bors

bors commented Oct 23, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit e105697 has been approved by alexcrichton

@glaubitz

glaubitz commented Oct 23, 2017

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton I think you picked the wrong commit. My first mapping was incorrect.

Could you please make sure you are merging b9f2cfb?

Thanks

@kennytm

kennytm commented Oct 24, 2017

Copy link
Copy Markdown
Member

@bors r=alexcrichton b9f2cfb

@bors

bors commented Oct 24, 2017

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Oct 24, 2017

Copy link
Copy Markdown
Collaborator

🙀 b9f2cfb is not a valid commit SHA. Please try again with e105697.

@kennytm

kennytm commented Oct 24, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@glaubitz Perhaps try to amend and force-push a new commit. Bors is not recognizing the new commit.

@bors r-

@kennytmkennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2017
@glaubitz

glaubitz commented Oct 24, 2017

Copy link
Copy Markdown
ContributorAuthor

@kennytm Thanks. I have rebased and pushed 929a8bc.

@kennytm

kennytm commented Oct 24, 2017

Copy link
Copy Markdown
Member

@bors r=alexcrichton 929a8bc

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 25, 2017
@GuillaumeGomez
Rollup merge ofrust-lang#45465- glaubitz:sparc64, r=alexcrichton
e09585c
bootstrap: Add openssl configuration for sparc64-unknown-linux-gnu
Hi!
This adds the target missing mapping for sparc64-unknown-linux-gnu.
See: rust-lang#45456
Thanks
@GuillaumeGomezGuillaumeGomez mentioned this pull request Oct 25, 2017
Merged
bors added a commit that referenced this pull request Oct 25, 2017
@bors
Auto merge of#45513- GuillaumeGomez:rollup, r=GuillaumeGomez
2f5ae25
Rollup of 5 pull requests
- Successful merges: #45361, #45461, #45465, #45486, #45502
- Failed merges:
@bors
bors merged commit 929a8bc into rust-lang:masterOct 25, 2017
@glaubitzglaubitz mentioned this pull request Oct 25, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jrtc27jrtc27jrtc27 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@glaubitz@rust-highfive@Mark-Simulacrum@alexcrichton@bors@kennytm@jrtc27@aturon