Skip to content

Implement From<RecvError> for TryRecvError and RecvTimeoutError - #45506

Merged
bors merged 2 commits into
rust-lang:masterfrom
ia0:mpsc_recv_error_from
Nov 28, 2017
Merged

Implement From<RecvError> for TryRecvError and RecvTimeoutError#45506
bors merged 2 commits into
rust-lang:masterfrom
ia0:mpsc_recv_error_from

Conversation

@ia0

@ia0ia0 commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

According to the documentation, it looks to me that TryRecvError and RecvTimeoutError are strict extensions of RecvError. As such, it makes sense to allow conversion from the latter type to the two former types without constraining future developments.

This permits to write input.recv()? and input.recv_timeout(timeout)? in the same function for example.

@rust-highfive

rust-highfive commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytmkennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api [DEPRECATED; DO NOT USE] labels Oct 25, 2017
@carols10cents

carols10cents commented Oct 30, 2017

Copy link
Copy Markdown
Member

ping for review @aturon ! pinging you in chat too!

@ia0

ia0 commented Oct 30, 2017

Copy link
Copy Markdown
ContributorAuthor

For completeness, I also added a conversion from SendError to TrySendError in the second and currently last commit.

@shepmaster

shepmaster commented Nov 3, 2017

Copy link
Copy Markdown
Member

Reassigning to new libs team member...

r? @BurntSushi

@BurntSushi

BurntSushi commented Nov 7, 2017•
edited by shepmaster
Loading

Copy link
Copy Markdown
Member

This seems reasonable to me.

@rfcbot fcp merge

@shepmaster

shepmaster commented Nov 8, 2017

Copy link
Copy Markdown
Member

@BurntSushi It sounds like the fcp call-to-action needs to be on it's own line. I edited your comment, but no joy 😸.

@kennytmkennytm added S-waiting-on-team and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2017
@kennytm

kennytm commented Nov 12, 2017

Copy link
Copy Markdown
Member

Hi @rust-lang/libs, it seems @rfcbot isn't responding, could anyone re-issue the FCP request?

@dtolnay

dtolnay commented Nov 12, 2017

Copy link
Copy Markdown
Member

@rfcbot fcp merge

@rfcbot

rfcbot commented Nov 12, 2017•
edited by aturon
Loading

Copy link
Copy Markdown

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbotrfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Nov 12, 2017
@rfcbot

rfcbot commented Nov 21, 2017

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbotrfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Nov 21, 2017
@kennytmkennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-team labels Nov 23, 2017
@alexcrichton

alexcrichton commented Nov 27, 2017

Copy link
Copy Markdown
Member

@bors: r+

Thanks!

@bors

bors commented Nov 27, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 448215d has been approved by alexcrichton

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 27, 2017
@kennytm
Rollup merge ofrust-lang#45506- ia0:mpsc_recv_error_from, r=alexcri…
2f012e4
…chton
Implement From<RecvError> for TryRecvError and RecvTimeoutError
According to the documentation, it looks to me that `TryRecvError` and `RecvTimeoutError` are strict extensions of `RecvError`. As such, it makes sense to allow conversion from the latter type to the two former types without constraining future developments.
This permits to write `input.recv()?` and `input.recv_timeout(timeout)?` in the same function for example.
@kennytmkennytm mentioned this pull request Nov 27, 2017
Merged
@ia0ia0 mentioned this pull request Nov 27, 2017
Merged
bors added a commit that referenced this pull request Nov 27, 2017
@bors
Auto merge of#46312- kennytm:rollup, r=kennytm
b087a99
Rollup of 10 pull requests
- Successful merges: #45506, #46174, #46231, #46240, #46249, #46258, #46262, #46275, #46282, #46285
- Failed merges:
@Mark-Simulacrum

Mark-Simulacrum commented Nov 28, 2017

Copy link
Copy Markdown
Member

@bors rollup

@Mark-Simulacrum

Mark-Simulacrum commented Nov 28, 2017

Copy link
Copy Markdown
Member

@ia0 Since this will land into the 1.24 release train, would you be interested in changing the since annotation (preferably in another PR to avoid rollup confusion)? If not, please file an issue to make sure that happens.

@bors
bors merged commit 448215d into rust-lang:masterNov 28, 2017
@ia0ia0 mentioned this pull request Nov 28, 2017
Merged
@ia0
ia0 deleted the mpsc_recv_error_from branch November 28, 2017 09:53
@ia0

ia0 commented Nov 28, 2017

Copy link
Copy Markdown
ContributorAuthor

Thanks for the information @Mark-Simulacrum. I created #46323 to fix the issue.

kennytm added a commit to kennytm/rust that referenced this pull request Nov 29, 2017
@kennytm
Rollup merge ofrust-lang#46323- ia0:fix_mpsc_error_conv, r=kennytm
30f1853
Fix since for mpsc_error_conversions
This is a followup of rust-lang#45506.
@ghostghost mentioned this pull request Dec 12, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BurntSushiBurntSushi

Labels

final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@ia0@rust-highfive@carols10cents@shepmaster@BurntSushi@kennytm@dtolnay@rfcbot@alexcrichton@bors@Mark-Simulacrum@aturon