Skip to content

Document non-obvious behavior of fmt::UpperHex & co for negative integers - #46285

Merged
bors merged 1 commit into
rust-lang:masterfrom
SimonSapin:twos-complement
Nov 28, 2017
Merged

Document non-obvious behavior of fmt::UpperHex & co for negative integers#46285
bors merged 1 commit into
rust-lang:masterfrom
SimonSapin:twos-complement

Conversation

@SimonSapin

@SimonSapinSimonSapin commented Nov 26, 2017

Copy link
Copy Markdown
Contributor

Before stabilization I’d have suggested changing the behavior, but that time is past.

@SimonSapin
Document non-obvious behavior of fmt::UpperHex & co for negative inte…
a326d8d
…gers
Before stabilization I’d have suggested changing the behavior,
but that time is past.
@rust-highfive

rust-highfive commented Nov 26, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@SimonSapin

SimonSapin commented Nov 26, 2017

Copy link
Copy Markdown
ContributorAuthor

Maybe these doc-comments should be on respective impls instead?

@kennytmkennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Nov 27, 2017
@kennytm

kennytm commented Nov 27, 2017

Copy link
Copy Markdown
Member

Reassigning to docs team — r? @GuillaumeGomez

@SimonSapinSimonSapin mentioned this pull request Nov 27, 2017
Closed
@GuillaumeGomez

GuillaumeGomez commented Nov 27, 2017

Copy link
Copy Markdown
Member

Sounds good. Thanks!

@bors: r+ rollup

@bors

bors commented Nov 27, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit a326d8d has been approved by GuillaumeGomez

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 27, 2017
@kennytm
Rollup merge ofrust-lang#46285- SimonSapin:twos-complement, r=Guill…
83a6f38
…aumeGomez
Document non-obvious behavior of fmt::UpperHex & co for negative integers
Before stabilization I’d have suggested changing the behavior, but that time is past.
@kennytmkennytm mentioned this pull request Nov 27, 2017
Merged
bors added a commit that referenced this pull request Nov 27, 2017
@bors
Auto merge of#46312- kennytm:rollup, r=kennytm
b087a99
Rollup of 10 pull requests
- Successful merges: #45506, #46174, #46231, #46240, #46249, #46258, #46262, #46275, #46282, #46285
- Failed merges:
@bors
bors merged commit a326d8d into rust-lang:masterNov 28, 2017
@SimonSapin
SimonSapin deleted the twos-complement branch November 28, 2017 07:35
@PhlosioneerPhlosioneer mentioned this pull request Mar 11, 2018
Closed
@cmcqueen

cmcqueen commented Jun 23, 2021

Copy link
Copy Markdown

Before stabilization I’d have suggested changing the behavior, but that time is past.

Is there any chance this can be changed in a Rust edition? Eg the upcoming 2021 edition.

@kennytm

kennytm commented Jun 23, 2021

Copy link
Copy Markdown
Member

No, the runtime behavior is edition-agnostic in the since they share the same libcore. That means we either change it for all of 2015/2018/2021 starting from Rust 1.XX or never change it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@SimonSapin@rust-highfive@kennytm@GuillaumeGomez@bors@cmcqueen@alexcrichton