Uh oh!
There was an error while loading. Please reload this page.
Fix help for duplicated names: extern crate (...) as (...) - #45856
Merged
Conversation
rust-highfive
commented
Nov 8, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
nikomatsakis
approved these changes
Nov 8, 2017
Contributor
There was a problem hiding this comment.
FWIW, I find this message confusing. I think it's the phrasing "import of the extern crate m1", whereas I see this statement as importing the crate m2 -- but aliasing it to m1. I wonder if some small tweaks to the wording might help. Or maybe it's just fine as is, it's kind of a corner case, and if all goes to plan extern crate is going away anyway.
nikomatsakis
commented
Nov 8, 2017
Contributor
@bors r+ -- larger changes seem out of scope |
bors
commented
Nov 8, 2017
Collaborator
📌 Commit 3bd7b92 has been approved by |
On the case of duplicated names caused by an `extern crate` statement with a rename, don't include the inline suggestion, instead using a span label with only the text to avoid incorrect rust code output.
estebank
commented
Nov 8, 2017
ContributorAuthor
@bors r=nikomatsakis |
bors
commented
Nov 8, 2017
Collaborator
📌 Commit d0339c7 has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Nov 10, 2017
Fix help for duplicated names: `extern crate (...) as (...)` On the case of duplicated names caused by an `extern crate` statement with a rename, don't include the inline suggestion, instead using a span label with only the text to avoid incorrect rust code output. Fixrust-lang#45829.
bors added a commit
that referenced
this pull request
Nov 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the case of duplicated names caused by an
extern cratestatementwith a rename, don't include the inline suggestion, instead using a span
label with only the text to avoid incorrect rust code output.
Fix#45829.