Skip to content

Allow a trailling comma in assert_eq/ne macro - #45887

Merged
bors merged 1 commit into
rust-lang:masterfrom
sugar700:assert-eq-trailling-comma
Nov 10, 2017
Merged

Allow a trailling comma in assert_eq/ne macro#45887
bors merged 1 commit into
rust-lang:masterfrom
sugar700:assert-eq-trailling-comma

Conversation

@sugar700

@sugar700sugar700 commented Nov 9, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

From Rust beginners IRC:

<???> It sure does annoy me that assert_eq!() does not accept a trailing comma after the last argument.
<???> ???: File an issue against https://github.com/rust-lang/rust and CC @rust-lang/libs

Figured that might as well submit it. Will become insta-stable after merging (danger zone).

cc @rust-lang/libs

@sugar700
sugar700force-pushed the assert-eq-trailling-comma branch from 344c59f to 9b2e78aCompareNovember 9, 2017 11:48
@kennytmkennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api [DEPRECATED; DO NOT USE] labels Nov 9, 2017
@kennytm

kennytm commented Nov 9, 2017

Copy link
Copy Markdown
Member

cc @rust-lang/libs @zackmdavis

@sugar700

sugar700 commented Nov 9, 2017

Copy link
Copy Markdown
ContributorAuthor

By the way, assert_eq!(1, 1, "description",); already works due to format_args macro allowing trailing commas.

@sugar700
sugar700force-pushed the assert-eq-trailling-comma branch from 9b2e78a to 5e1f697CompareNovember 9, 2017 12:48
@sugar700
sugar700force-pushed the assert-eq-trailling-comma branch from 5e1f697 to 6a92c0fCompareNovember 9, 2017 13:15
dtolnay
dtolnay approved these changes Nov 9, 2017
View reviewed changes

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems good to me.

@dtolnay

dtolnay commented Nov 9, 2017

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 9, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 6a92c0f has been approved by dtolnay

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 10, 2017
@kennytm
Rollup merge ofrust-lang#45887- xfix:assert-eq-trailling-comma, r=d…
253d18e
…tolnay
Allow a trailling comma in assert_eq/ne macro
From Rust beginners IRC:
&lt;???> It sure does annoy me that assert_eq!() does not accept a trailing comma after the last argument.
&lt;???> ???: File an issue against https://github.com/rust-lang/rust and CC @rust-lang/libs
Figured that might as well submit it. Will become insta-stable after merging (danger zone).
cc @rust-lang/libs
@kennytmkennytm mentioned this pull request Nov 10, 2017
Merged
bors added a commit that referenced this pull request Nov 10, 2017
@bors
Auto merge of#45907- kennytm:rollup, r=kennytm
c0d326f
Rollup of 9 pull requests
- Successful merges: #45783, #45856, #45863, #45869, #45878, #45882, #45887, #45895, #45901
- Failed merges:
@bors
bors merged commit 6a92c0f into rust-lang:masterNov 10, 2017
@colin-kiegelcolin-kiegel mentioned this pull request Nov 26, 2017
Closed
@dtolnaydtolnay self-assigned this Mar 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnaydtolnaydtolnay approved these changes

Assignees

@dtolnaydtolnay

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sugar700@kennytm@dtolnay@bors