Uh oh!
There was an error while loading. Please reload this page.
Adding eprint*! to the list of macros in the format! family - #46201
Merged
Conversation
rust-highfive
commented
Nov 23, 2017
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @withoutboats (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
frewsxcv
commented
Nov 24, 2017
Contributor
good catch! thanks for your contribution ✨ @bors r+ rollup |
bors
commented
Nov 24, 2017
Collaborator
📌 Commit 2f51f67 has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Nov 25, 2017
…wsxcv Adding `eprint*!` to the list of macros in the `format!` family The `eprint!` and `eprintln!` macros were added in 7612727. The `std::fmt` documentation does not mention these macros next to `print!` and `println!` in the [Related macros](https://doc.rust-lang.org/std/fmt/#related-macros) section, and I did not find evidence that this omission was deliberate. This PR adds such documentation. The first modification is to add `eprint!` and `eprintln!` to the list of related macros in the `format!` family. This is how it appears with this change:  The second modification adds a sub-section for `eprint!` and `eprintln!`. Here is how the new section appears: 
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Nov 26, 2017
…wsxcv Adding `eprint*!` to the list of macros in the `format!` family The `eprint!` and `eprintln!` macros were added in 7612727. The `std::fmt` documentation does not mention these macros next to `print!` and `println!` in the [Related macros](https://doc.rust-lang.org/std/fmt/#related-macros) section, and I did not find evidence that this omission was deliberate. This PR adds such documentation. The first modification is to add `eprint!` and `eprintln!` to the list of related macros in the `format!` family. This is how it appears with this change:  The second modification adds a sub-section for `eprint!` and `eprintln!`. Here is how the new section appears: 
bors added a commit
that referenced
this pull request
Nov 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
eprint!andeprintln!macros were added in 7612727. Thestd::fmtdocumentation does not mention these macros next toprint!andprintln!in the Related macros section, and I did not find evidence that this omission was deliberate. This PR adds such documentation.The first modification is to add
eprint!andeprintln!to the list of related macros in theformat!family. This is how it appears with this change:The second modification adds a sub-section for
eprint!andeprintln!. Here is how the new section appears: