Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #46266
Closed
kennytm wants to merge 14 commits into
Closed
Conversation
Provides the following conversion implementations:
* `From<`{`CString`,`&CStr`}`>` for {`Arc`,`Rc`}`<CStr>`
* `From<`{`OsString`,`&OsStr`}`>` for {`Arc`,`Rc`}`<OsStr>`
* `From<`{`PathBuf`,`&Path`}`>` for {`Arc`,`Rc`}`<Path>`
Closesrust-lang#45008Implement `Rc`/`Arc` conversions for string-like types
Provides the following conversion implementations:
* `From<`{`CString`,`&CStr`}`>` for {`Arc`,`Rc`}`<CStr>`
* `From<`{`OsString`,`&OsStr`}`>` for {`Arc`,`Rc`}`<OsStr>`
* `From<`{`PathBuf`,`&Path`}`>` for {`Arc`,`Rc`}`<Path>`
Closesrust-lang#45008…wsxcv Adding `eprint*!` to the list of macros in the `format!` family The `eprint!` and `eprintln!` macros were added in 7612727. The `std::fmt` documentation does not mention these macros next to `print!` and `println!` in the [Related macros](https://doc.rust-lang.org/std/fmt/#related-macros) section, and I did not find evidence that this omission was deliberate. This PR adds such documentation. The first modification is to add `eprint!` and `eprintln!` to the list of related macros in the `format!` family. This is how it appears with this change:  The second modification adds a sub-section for `eprint!` and `eprintln!`. Here is how the new section appears: 
…uietMisdreavus Remove invalid doc link r? @rust-lang/docs
core::marker fix typo
Update MSVC compilation instructions regarding path length on Windows Fixrust-lang#46214
Derive Debug for LangItem
InstCombine Len([_; N]) => const N in MIR A small opportunity I noticed in passing. Not super exciting on its own, but opens the door for a const propagation pass that could completely remove const bounds checks from arrays at MIR time, for example.
rust-highfive
commented
Nov 25, 2017
Contributor
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
commented
Nov 25, 2017
MemberAuthor
@bors r+ p=7 |
bors
commented
Nov 25, 2017
Collaborator
📌 Commit 38003ef has been approved by |
bors
commented
Nov 25, 2017
Collaborator
⌛ Testing commit 38003ef with merge 4787f66a46aa9b47ca64bfcff514f3795d1003f5... |
bors
commented
Nov 25, 2017
Collaborator
💔 Test failed - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rc/Arcconversions for string-like types #45990, Addingeprint*!to the list of macros in theformat!family #46201, Remove invalid doc link #46224, core::marker fix typo #46234, Update MSVC compilation instructions regarding path length on Windows #46252, Derive Debug for LangItem #46259, InstCombine Len([_; N]) => const N in MIR #46264