Skip to content

Clarify docs for split_at_mut - #46930

Merged
bors merged 1 commit into
rust-lang:masterfrom
0xSiO:patch-1
Dec 26, 2017
Merged

Clarify docs for split_at_mut#46930
bors merged 1 commit into
rust-lang:masterfrom
0xSiO:patch-1

Conversation

@0xSiO

@0xSiO0xSiO commented Dec 21, 2017

Copy link
Copy Markdown

The &mut here didn't make immediate sense to me. Keep the docs for this function consistent with the non-mut version.

@lucis-fluxum
Clarify docs for split_at_mut
8a956e4
The `&mut` here didn't make immediate sense to me. Keep the docs for this function consistent with the non-mut version.
@rust-highfive

rust-highfive commented Dec 21, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Kimundi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@QuietMisdreavus

QuietMisdreavus commented Dec 21, 2017

Copy link
Copy Markdown
Contributor

Ooh, i like this one better, thanks!

@bors r+ rollup

@bors

bors commented Dec 21, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 8a956e4 has been approved by QuietMisdreavus

@kennytmkennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 22, 2017
@kennytmkennytm mentioned this pull request Dec 23, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Dec 23, 2017
@kennytm
Rollup merge ofrust-lang#46930- lucis-fluxum:patch-1, r=QuietMisdre…
089e617
…avus
Clarify docs for split_at_mut
The `&mut` here didn't make immediate sense to me. Keep the docs for this function consistent with the non-mut version.
@kennytmkennytm mentioned this pull request Dec 23, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Dec 23, 2017
@kennytm
Rollup merge ofrust-lang#46930- lucis-fluxum:patch-1, r=QuietMisdre…
f6e1c4f
…avus
Clarify docs for split_at_mut
The `&mut` here didn't make immediate sense to me. Keep the docs for this function consistent with the non-mut version.
@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8a956e4 with merge 1fb8e77d2b262776fc6a822328ac4808ad9a1b4c...

@bors

bors commented Dec 25, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@kennytm

kennytm commented Dec 25, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@bors retry #47002

@bors

bors commented Dec 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8a956e4 with merge 4b5df5aacbb1ae70293dc77009de37f39a154cbd...

@bors

bors commented Dec 26, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

kennytm added a commit to kennytm/rust that referenced this pull request Dec 26, 2017
@kennytm
Rollup merge ofrust-lang#46930- lucis-fluxum:patch-1, r=QuietMisdre…
ba39972
…avus
Clarify docs for split_at_mut
The `&mut` here didn't make immediate sense to me. Keep the docs for this function consistent with the non-mut version.
@kennytmkennytm mentioned this pull request Dec 26, 2017
Merged
bors added a commit that referenced this pull request Dec 26, 2017
@bors
Auto merge of#47012- kennytm:rollup, r=kennytm
8cdde6d
Rollup of 8 pull requests
- Successful merges: #46928, #46930, #46933, #46939, #46940, #46943, #46979, #46986
- Failed merges:
@bors
bors merged commit 8a956e4 into rust-lang:masterDec 26, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@steveklabniksteveklabniksteveklabnik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@KimundiKimundi

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@0xSiO@rust-highfive@QuietMisdreavus@bors@kennytm@steveklabnik@Kimundi@lucis-fluxum