Uh oh!
There was an error while loading. Please reload this page.
Add "Basic Usage" to int min_value and max_value docs - #46986
Conversation
rust-highfive
commented
Dec 24, 2017
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
steveklabnik
commented
Dec 25, 2017
via email
Thanks so much!
@bors: r+ rollup …On Sun, Dec 24, 2017 at 2:04 PM, Rust highfive robot < ***@***.***> wrote:
r? @sfackler <https://github.com/sfackler>
(rust_highfive has picked a reviewer for you, use r? to override)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#46986 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABsipELfFEaa0nrge1b2kvEA8BoSKAFks5tDqBIgaJpZM4RL_o2>
.
|
bors
commented
Dec 25, 2017
📌 Commit c08a51c has been approved by |
bors
commented
Dec 25, 2017
⌛ Testing commit c08a51c with merge 5477c23a72670d296bf20879c11ac5313bce7f26... |
bors
commented
Dec 25, 2017
💔 Test failed - status-travis |
nvzqz
commented
Dec 25, 2017
@steveklabnik should all |
bors
commented
Dec 26, 2017
⌛ Testing commit c08a51c with merge bf0ee965ba4a85e6c395ea7fc229e45d2ff3dd28... |
bors
commented
Dec 26, 2017
💔 Test failed - status-travis |
Add "Basic Usage" to int min_value and max_value docs This adds "Basic Usage:" to the docs of `min_value` and `max_value`, which makes it consistent with docs of other integer methods.
steveklabnik
commented
Dec 26, 2017
@nvzqzhttps://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md is the guidelines, which don't technically contain them. I actually thought that they did contain this, though, heh. It is a thing we do in stdlib sometimes. |
This adds "Basic Usage:" to the docs of
min_valueandmax_value, which makes it consistent with docs of other integer methods.