Uh oh!
There was an error while loading. Please reload this page.
fix off-by-one error - #47330
Conversation
rust-highfive
commented
Jan 10, 2018
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
steveklabnik
commented
Jan 10, 2018
Nice catch, thank you! @bors: r+ rollup |
bors
commented
Jan 10, 2018
📌 Commit 0e9dde9 has been approved by |
nixpulvis
commented
Jan 10, 2018
Maybe use an inclusive range to be more clear? |
@nixpulvis, you mean 0..10? |
nixpulvis
commented
Jan 10, 2018
Nope, though now that I'm playing with it it looks like it's experamental and kinda a mess imho, see #28237. Inclusive ranges (in this context) include the last element as well as the rest. |
nixpulvis
commented
Jan 10, 2018
I would however strongly encourage a change to |
This change is now incorrect. The documentation says:
The code now writes the numbers from zero through nine. You should add one to |
bmusin
commented
Jan 11, 2018
@varkor, you meant this? |
nixpulvis
commented
Jan 11, 2018
@varkor oh nice catch, I should have read the docs more carefully before suggesting |
shepmaster
commented
Jan 13, 2018
Looks great @bmusin! Please go ahead and squash these commits and we will be good to merge! |
bmusin
commented
Jan 13, 2018
Squashed. |
shepmaster
commented
Jan 13, 2018
Thanks! @bors: r+ rollup |
bors
commented
Jan 13, 2018
📌 Commit cee295e has been approved by |
fix off-by-one error Fixesrust-lang#47325.
fix off-by-one error Fixesrust-lang#47325.
Fixes#47325.