Skip to content

Avoid panicking when invalid argument is passed to cfg(..) - #47372

Merged
bors merged 1 commit into
rust-lang:masterfrom
topecongiro:issue-43925
Jan 15, 2018
Merged

Avoid panicking when invalid argument is passed to cfg(..)#47372
bors merged 1 commit into
rust-lang:masterfrom
topecongiro:issue-43925

Conversation

@topecongiro

@topecongirotopecongiro commented Jan 12, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#43925.
Closes#43926.

@rust-highfive

rust-highfive commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@topecongiro

topecongiro commented Jan 12, 2018

Copy link
Copy Markdown
ContributorAuthor

Updated the PR to handle when cfg(..) has no argument (cc #43926).

@shepmastershepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2018
@arielb1

arielb1 commented Jan 13, 2018

Copy link
Copy Markdown
Contributor

r? @alexcrichton

@alexcrichton

alexcrichton commented Jan 13, 2018

Copy link
Copy Markdown
Member

@bors: r+

Thanks @topecongiro!

@bors

bors commented Jan 13, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit d088b25 has been approved by alexcrichton

@kennytmkennytm mentioned this pull request Jan 15, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Jan 15, 2018
@kennytm
Rollup merge ofrust-lang#47372- topecongiro:issue-43925, r=alexcric…
f98a9a6
…hton
Avoid panicking when invalid argument is passed to cfg(..)
Closesrust-lang#43925.
Closesrust-lang#43926.
bors added a commit that referenced this pull request Jan 15, 2018
@bors
Auto merge of#47445- kennytm:rollup, r=kennytm
57850e5
Rollup of 10 pull requests
- Successful merges: #47120, #47126, #47277, #47330, #47368, #47372, #47414, #47417, #47432, #47443
- Failed merges: #47334
@bors
bors merged commit d088b25 into rust-lang:masterJan 15, 2018
@topecongiro
topecongiro deleted the issue-43925 branch January 15, 2018 15:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pnkfelixpnkfelix

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@topecongiro@rust-highfive@arielb1@alexcrichton@bors@pnkfelix@shepmaster